Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 1316863003: Fix TestExpectations lint error after http://src.chromium.org/viewvc/blink?view=revision&revision=2… (Closed)

Created:
5 years, 3 months ago by cbiesinger
Modified:
5 years, 3 months ago
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M LayoutTests/TestExpectations View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
cbiesinger
Committed patchset #1 (id:1) manually as 201255 (presubmit successful).
5 years, 3 months ago (2015-08-26 22:21:20 UTC) #1
mnaganov (inactive)
5 years, 3 months ago (2015-08-26 22:43:12 UTC) #2
Message was sent while issue was closed.
Thanks! My bad -- forgot to run lint :(

On Wed, Aug 26, 2015 at 3:21 PM, cbiesinger@chromium.org via
codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote:

> Reviewers: mnaganov,
>
> Message:
> Committed patchset #1 (id:1) manually as 201255 (presubmit successful).
>
> Description:
> Fix TestExpectations lint error after
> http://src.chromium.org/viewvc/blink?view=revision&revision=201246
>
> BUG=524248
> TBR=mnaganov@chromium.org
> NOTRY=true
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201255
>
> Please review this at https://codereview.chromium.org/1316863003/
>
> Base URL: svn://svn.chromium.org/blink/trunk
>
> Affected files (+3, -3 lines):
>   M LayoutTests/TestExpectations
>
>
> Index: LayoutTests/TestExpectations
> diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
> index
>
5cd75cfbcf9d4d16f88fde873c9c83a683bcc5c0..6217adcbdb2763add09a22b07edb1b5c225928db
> 100644
> --- a/LayoutTests/TestExpectations
> +++ b/LayoutTests/TestExpectations
> @@ -1,4 +1,6 @@
> -crbug.com/504613 paint/images/image-backgrounds-not-antialiased.html [
> ImageOnlyFailure ]
> +# also crbug.com/524248
> +crbug.com/504613 paint/images/image-backgrounds-not-antialiased.html [
> Skip ]
> +
>  crbug.com/502531 fast/borders/border-antialiasing.html [
> ImageOnlyFailure ]
>
>  crbug.com/417782 [ Linux Win ]
>
virtual/rootlayerscrolls/fast/scrolling/fractional-scroll-offset-fixed-position-non-composited.html
> [ ImageOnlyFailure ]
> @@ -1549,5 +1551,3 @@ crbug.com/524804 [ Win10 ]
> animations/svg-attribute-interpolation/svg-xChannelSe
>  crbug.com/524826 [ Win10 ]
> compositing/squashing/squashing-reflection-disallowed.html [ Pass Timeout ]
>
>  crbug.com/525065 webaudio/audionode-disconnect-audioparam.html [ Failure
> Pass ]
> -
> -crbug.com/524248 [ Lion ]
> paint/images/image-backgrounds-not-antialiased.html [ Skip ]
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698