Round glyph width and bounds if !SkPaint.isSubpixelText() in complex path

Source/platform/fonts/shaping/HarfBuzzFace.cpp

 /*
  * Copyright (c) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 128 matching lines @@
 static void SkiaGetGlyphWidthAndExtents(SkPaint* paint, hb_codepoint_t codepoint, hb_position_t* width, hb_glyph_extents_t* extents)
 {
     ASSERT(codepoint <= 0xFFFF);
     paint->setTextEncoding(SkPaint::kGlyphID_TextEncoding);
 
     SkScalar skWidth;
     SkRect skBounds;
     uint16_t glyph = codepoint;
 
     paint->getTextWidths(&glyph, sizeof(glyph), &skWidth, &skBounds);
-    if (width)
+    if (width) {
+        if (!paint->isSubpixelText())
+            skWidth = SkScalarRoundToInt(skWidth);
         *width = SkiaScalarToHarfBuzzPosition(skWidth);
+    }
     if (extents) {
+        if (!paint->isSubpixelText()) {

[eae, 2015/09/01 16:24:38]

Would you mind adding a comment here as to why we're using roundOut?

+            SkIRect ir;
+            skBounds.roundOut(&ir);
+            skBounds.set(ir);
+        }
         // Invert y-axis because Skia is y-grows-down but we set up HarfBuzz to be y-grows-up.
         extents->x_bearing = SkiaScalarToHarfBuzzPosition(skBounds.fLeft);
         extents->y_bearing = SkiaScalarToHarfBuzzPosition(-skBounds.fTop);
         extents->width = SkiaScalarToHarfBuzzPosition(skBounds.width());
         extents->height = SkiaScalarToHarfBuzzPosition(-skBounds.height());
     }
 }
 
 #if !defined(HB_VERSION_ATLEAST)
 #define HB_VERSION_ATLEAST(major, minor, micro) 0
@@ skipping 175 matching lines @@
     hb_font_t* font = hb_font_create(m_face);
     hb_font_set_funcs(font, harfBuzzSkiaGetFontFuncs(), hbFontData, destroyHarfBuzzFontData);
     float size = m_platformData->size();
     int scale = SkiaScalarToHarfBuzzPosition(size);
     hb_font_set_scale(font, scale, scale);
     hb_font_make_immutable(font);
     return font;
 }
 
 } // namespace blink