bindings: Support (deprecated) Dictionary in IDL dictionary

bindings: Support (deprecated) Dictionary in IDL dictionary

Supporting deprecated Dictionary enables us to do step-by-step refactoring.

Note for tests:
Since Dictionary instances cannot outlive an event loop, DictionaryTest
stores its properties intead of instances itself. Added
getDictionaryMemberProperties() to retrieve these properties.

BUG=524357
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201199

[bashi, 2015-08-25 23:57:08]

Patchset #1 (id:1) has been deleted

[bashi, 2015-08-26 00:31:31]

bashi@chromium.org changed reviewers:
+ haraken@chromium.org

[bashi, 2015-08-26 00:31:31]

PTAL?

[haraken, 2015-08-26 00:34:21]

Maybe another idea (that won't mess up the IDL compiler just for deprecated
features) would be to implement an operator! to Dictionary?

[bashi, 2015-08-26 00:37:12]

On 2015/08/26 00:34:21, haraken wrote:
> Maybe another idea (that won't mess up the IDL compiler just for deprecated
> features) would be to implement an operator! to Dictionary?

How can we generate a Dictionary to compare? There is no way to create an
instance outside binding layer.

[haraken, 2015-08-26 00:40:54]

ah, makes sense. LGTM.

https://codereview.chromium.org/1316833003/diff/20001/Source/bindings/scripts...
File Source/bindings/scripts/v8_dictionary.py (right):

https://codereview.chromium.org/1316833003/diff/20001/Source/bindings/scripts...
Source/bindings/scripts/v8_dictionary.py:120: 'is_object':
unwrapped_idl_type.name == 'Object',

Maybe it would be better to change this to:

  'is_object': unwrapped_idl_type.name == 'Object' or is_deprecated_dictionary

instead of introducing 'is_deprecated_dictionary'.

[bashi, 2015-08-26 00:48:15]

Thanks!

https://codereview.chromium.org/1316833003/diff/20001/Source/bindings/scripts...
File Source/bindings/scripts/v8_dictionary.py (right):

https://codereview.chromium.org/1316833003/diff/20001/Source/bindings/scripts...
Source/bindings/scripts/v8_dictionary.py:120: 'is_object':
unwrapped_idl_type.name == 'Object',
On 2015/08/26 00:40:54, haraken wrote:
> 
> Maybe it would be better to change this to:
> 
>   'is_object': unwrapped_idl_type.name == 'Object' or is_deprecated_dictionary
> 
> instead of introducing 'is_deprecated_dictionary'.

Done.

[bashi, 2015-08-26 00:48:54]

The CQ bit was checked by bashi@chromium.org

[bashi, 2015-08-26 00:48:54]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1316833003/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-08-26 00:49:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1316833003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1316833003/40001

[commit-bot: I haz the power, 2015-08-26 03:50:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-26 03:50:18]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[bashi, 2015-08-26 04:26:32]

The CQ bit was checked by bashi@chromium.org

[commit-bot: I haz the power, 2015-08-26 04:26:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1316833003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1316833003/40001

[commit-bot: I haz the power, 2015-08-26 05:33:09]

Committed patchset #2 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201199