Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 131683003: Password manager: Enabling Public Suffix List matching on Windows. (Closed)

Created:
6 years, 11 months ago by vabr (Chromium)
Modified:
6 years, 11 months ago
Reviewers:
Garrett Casto
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Password manager: Enabling Public Suffix List matching on Windows. The PSL matching seems to work already on Windows, because it only depends on the platform-independent parts of login_database.cc. After manually verifying that it works (with a Release ToT build), I'd like to enable it on trunk in this CL. I will make sure that this change does not propagate to beta and stable before it passes all the reviews in the launch bug (linked from the BUG below). BUG=324291 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244172

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/about_flags.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/psl_matching_helper.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
vabr (Chromium)
Hi Garrett, It turns out that fuzzy matching works already on Windows. This CL only ...
6 years, 11 months ago (2014-01-09 13:36:00 UTC) #1
Garrett Casto
lgtm
6 years, 11 months ago (2014-01-09 18:58:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vabr@chromium.org/131683003/1
6 years, 11 months ago (2014-01-10 11:20:47 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) check_deps2git http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=190219
6 years, 11 months ago (2014-01-10 13:00:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vabr@chromium.org/131683003/1
6 years, 11 months ago (2014-01-10 13:07:46 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-10 15:29:20 UTC) #6
Message was sent while issue was closed.
Change committed as 244172

Powered by Google App Engine
This is Rietveld 408576698