Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 1316803002: [Android] Add logging of active device_forwarders (Closed)

Created:
5 years, 3 months ago by rnephew (Reviews Here)
Modified:
5 years, 3 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Add logging of active device_forwarders When a forwarder fails to be created, it currently attempts to kill device_forwarder on the device. This adds logging after the kill attempt occurs so we can confirm that the device_forwarder is killed. BUG=520958 Committed: https://crrev.com/a32d6c654bacc903b179ade49ded6cba1a7c4443 Cr-Commit-Position: refs/heads/master@{#345607}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M build/android/pylib/forwarder.py View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
rnephew (Reviews Here)
5 years, 3 months ago (2015-08-25 21:14:58 UTC) #2
jbudorick
lgtm
5 years, 3 months ago (2015-08-26 12:58:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316803002/1
5 years, 3 months ago (2015-08-26 13:21:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-26 14:37:43 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-08-26 14:38:25 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a32d6c654bacc903b179ade49ded6cba1a7c4443
Cr-Commit-Position: refs/heads/master@{#345607}

Powered by Google App Engine
This is Rietveld 408576698