Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 1316793004: AccessibilityManager must be deleted after ash Shell, but before InputMethodManager. (Closed)

Created:
5 years, 3 months ago by achuithb
Modified:
5 years, 3 months ago
Reviewers:
oshima
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

AccessibilityManager must be deleted after ash Shell, but before InputMethodManager. session_state_observer_ needs to be deleted before the Shell goes away, so we do it in OnAppTerminating. BUG=chromium:515097 Committed: https://crrev.com/ecf113f67c8ff43e8eddeb2585c98bbc31ed79e2 Cr-Commit-Position: refs/heads/master@{#348130}

Patch Set 1 #

Patch Set 2 : SessionStateDelegate #

Total comments: 2

Patch Set 3 : OnAppTerminating #

Total comments: 3

Patch Set 4 : RemoveShellObserver #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -4 lines) Patch
M chrome/browser/chromeos/accessibility/accessibility_manager.h View 1 2 3 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_manager.cc View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc View 1 2 3 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 43 (17 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316793004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316793004/1
5 years, 3 months ago (2015-09-03 14:25:49 UTC) #2
achuithb
This fixes the shutdown ordering.
5 years, 3 months ago (2015-09-03 14:27:35 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/58780)
5 years, 3 months ago (2015-09-03 15:06:01 UTC) #6
oshima
yep, this is the right way to fix. lgtm
5 years, 3 months ago (2015-09-03 16:36:58 UTC) #7
oshima
looks like you have to reset the session state observer before shell is destroyed.
5 years, 3 months ago (2015-09-03 16:40:43 UTC) #8
achuithb
On 2015/09/03 16:40:43, oshima wrote: > looks like you have to reset the session state ...
5 years, 3 months ago (2015-09-03 17:38:35 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316793004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316793004/20001
5 years, 3 months ago (2015-09-04 13:41:03 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/59332)
5 years, 3 months ago (2015-09-04 14:16:07 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316793004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316793004/40001
5 years, 3 months ago (2015-09-07 07:47:50 UTC) #16
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/59850)
5 years, 3 months ago (2015-09-07 08:23:12 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316793004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316793004/60001
5 years, 3 months ago (2015-09-07 11:02:12 UTC) #21
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-07 11:55:29 UTC) #23
achuithb
Finally got it to not crash. Oshima-san, PTAL.
5 years, 3 months ago (2015-09-07 14:58:50 UTC) #24
oshima
https://codereview.chromium.org/1316793004/diff/60001/chrome/browser/chromeos/accessibility/accessibility_manager.cc File chrome/browser/chromeos/accessibility/accessibility_manager.cc (right): https://codereview.chromium.org/1316793004/diff/60001/chrome/browser/chromeos/accessibility/accessibility_manager.cc#newcode946 chrome/browser/chromeos/accessibility/accessibility_manager.cc:946: void AccessibilityManager::SessionEnded() { Is it possible to use ShellObserver::OnAppTerminating ...
5 years, 3 months ago (2015-09-08 21:06:03 UTC) #25
achuithb
PTAL, Oshima-san https://codereview.chromium.org/1316793004/diff/60001/chrome/browser/chromeos/accessibility/accessibility_manager.cc File chrome/browser/chromeos/accessibility/accessibility_manager.cc (right): https://codereview.chromium.org/1316793004/diff/60001/chrome/browser/chromeos/accessibility/accessibility_manager.cc#newcode946 chrome/browser/chromeos/accessibility/accessibility_manager.cc:946: void AccessibilityManager::SessionEnded() { On 2015/09/08 21:06:03, oshima ...
5 years, 3 months ago (2015-09-09 10:45:39 UTC) #26
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316793004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316793004/80001
5 years, 3 months ago (2015-09-09 10:48:48 UTC) #28
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-09 11:13:57 UTC) #30
oshima
lgtm with one nit https://codereview.chromium.org/1316793004/diff/80001/chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc File chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc (right): https://codereview.chromium.org/1316793004/diff/80001/chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc#newcode70 chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc:70: ~AccessibilityDelegateImpl() override {} can you ...
5 years, 3 months ago (2015-09-09 19:35:06 UTC) #31
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316793004/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316793004/100001
5 years, 3 months ago (2015-09-10 09:33:32 UTC) #33
achuithb
https://codereview.chromium.org/1316793004/diff/80001/chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc File chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc (right): https://codereview.chromium.org/1316793004/diff/80001/chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc#newcode70 chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc:70: ~AccessibilityDelegateImpl() override {} On 2015/09/09 19:35:06, oshima wrote: > ...
5 years, 3 months ago (2015-09-10 09:35:05 UTC) #34
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-10 09:59:05 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316793004/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316793004/100001
5 years, 3 months ago (2015-09-10 10:04:21 UTC) #39
achuithb
On 2015/09/09 19:35:06, oshima wrote: > lgtm with one nit > ty
5 years, 3 months ago (2015-09-10 10:04:28 UTC) #40
commit-bot: I haz the power
Committed patchset #4 (id:100001)
5 years, 3 months ago (2015-09-10 10:09:28 UTC) #41
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/ecf113f67c8ff43e8eddeb2585c98bbc31ed79e2 Cr-Commit-Position: refs/heads/master@{#348130}
5 years, 3 months ago (2015-09-10 10:10:21 UTC) #42
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:09:22 UTC) #43
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/ecf113f67c8ff43e8eddeb2585c98bbc31ed79e2
Cr-Commit-Position: refs/heads/master@{#348130}

Powered by Google App Engine
This is Rietveld 408576698