Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1316773004: --harmony-sloppy-function depends on --harmony-sloppy (Closed)

Created:
5 years, 4 months ago by Dan Ehrenberg
Modified:
5 years, 4 months ago
Reviewers:
adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

--harmony-sloppy-function depends on --harmony-sloppy The lack of marking this dependency led to a ClusterFuzz crash when sloppy-function was on but not sloppy. This case does not make sense. R=adamk LOG=N BUG=chromium:520891 Committed: https://crrev.com/884288166b9bd8202f5ada0c73f2f9c07affff34 Cr-Commit-Position: refs/heads/master@{#30364}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/flag-definitions.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Dan Ehrenberg
5 years, 4 months ago (2015-08-26 00:38:24 UTC) #1
adamk
lgtm
5 years, 4 months ago (2015-08-26 00:39:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316773004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316773004/1
5 years, 4 months ago (2015-08-26 00:43:50 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-26 01:12:49 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-26 01:13:03 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/884288166b9bd8202f5ada0c73f2f9c07affff34
Cr-Commit-Position: refs/heads/master@{#30364}

Powered by Google App Engine
This is Rietveld 408576698