Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1316763005: Use UintToString for unsigned values in //gpu (Closed)

Created:
5 years, 3 months ago by Adam Rice
Modified:
5 years, 3 months ago
Reviewers:
bajones
CC:
chromium-reviews, piman+watch_chromium.org, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use UintToString for unsigned values in //gpu BUG=505479 TEST=gpu_unittests Committed: https://crrev.com/40821361e9770a4b00cb7c58cfb6988a05cb5124 Cr-Commit-Position: refs/heads/master@{#346324}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/vertex_attrib_manager.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Adam Rice
5 years, 3 months ago (2015-08-28 20:21:10 UTC) #3
bajones
On 2015/08/28 20:21:10, Adam Rice wrote: LGTM
5 years, 3 months ago (2015-08-28 22:10:06 UTC) #4
bajones
On 2015/08/28 20:21:10, Adam Rice wrote: LGTM
5 years, 3 months ago (2015-08-28 22:10:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316763005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316763005/20001
5 years, 3 months ago (2015-08-29 18:21:32 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 3 months ago (2015-08-29 20:39:44 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-08-29 20:40:42 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/40821361e9770a4b00cb7c58cfb6988a05cb5124
Cr-Commit-Position: refs/heads/master@{#346324}

Powered by Google App Engine
This is Rietveld 408576698