Clean up default parameter computation in parser

runtime/vm/parser.h

Index: runtime/vm/parser.h
diff --git a/runtime/vm/parser.h b/runtime/vm/parser.h
index 1d7dbf751e35761b3499bae96cb5a6358e42c865..fc4a74be6e5b072260a3d0245e42575b3cda3e0c 100644
--- a/runtime/vm/parser.h
+++ b/runtime/vm/parser.h
@@ -87,6 +87,7 @@ class ParsedFunction : public ZoneAllocated {
 
   void set_default_parameter_values(ZoneGrowableArray<const Instance*>* list) {
     default_parameter_values_ = list;
+    if (list == NULL) return;

[hausner, 2015/08/25 21:21:56]

This should be inside the #if block.

[srdjan, 2015/08/25 21:49:40]

Done.

 #if defined(DEBUG)
     for (intptr_t i = 0; i < list->length(); i++) {
       ASSERT(list->At(i)->IsZoneHandle() || list->At(i)->InVMHeap());
@@ -100,6 +101,10 @@ class ParsedFunction : public ZoneAllocated {
     return *default_parameter_values_->At(i);
   }
 
+  ZoneGrowableArray<const Instance*>* default_parameter_values() const {
+    return default_parameter_values_;
+  }
+
   LocalVariable* current_context_var() const {
     return current_context_var_;
   }
@@ -518,9 +523,7 @@ class Parser : public ValueObject {
 
   static bool ParseFormalParameters(const Function& func, ParamList* params);
 
-  static void SetupDefaultsForOptionalParams(
-      const ParamList& params,
-      ZoneGrowableArray<const Instance*>* default_values);
+  void SetupDefaultsForOptionalParams(const ParamList& params);
   ClosureNode* CreateImplicitClosureNode(const Function& func,
                                          intptr_t token_pos,
                                          AstNode* receiver);
@@ -528,10 +531,8 @@ class Parser : public ValueObject {
                                         const Function& func);
   void AddFormalParamsToScope(const ParamList* params, LocalScope* scope);
 
-  SequenceNode* ParseConstructor(
-      const Function& func, ZoneGrowableArray<const Instance*>* default_values);
-  SequenceNode* ParseFunc(
-      const Function& func, ZoneGrowableArray<const Instance*>* default_values);
+  SequenceNode* ParseConstructor(const Function& func);
+  SequenceNode* ParseFunc(const Function& func);
 
   void ParseNativeFunctionBlock(const ParamList* params, const Function& func);
 
@@ -540,18 +541,13 @@ class Parser : public ValueObject {
   SequenceNode* ParseStaticFinalGetter(const Function& func);
   SequenceNode* ParseStaticInitializer();
   SequenceNode* ParseMethodExtractor(const Function& func);
-  SequenceNode* ParseNoSuchMethodDispatcher(
-      const Function& func, ZoneGrowableArray<const Instance*>* default_values);
-  SequenceNode* ParseInvokeFieldDispatcher(
-      const Function& func, ZoneGrowableArray<const Instance*>* default_values);
-  SequenceNode* ParseImplicitClosure(
-      const Function& func, ZoneGrowableArray<const Instance*>* default_values);
-  SequenceNode* ParseConstructorClosure(
-      const Function& func, ZoneGrowableArray<const Instance*>* default_values);
+  SequenceNode* ParseNoSuchMethodDispatcher(const Function& func);
+  SequenceNode* ParseInvokeFieldDispatcher(const Function& func);
+  SequenceNode* ParseImplicitClosure(const Function& func);
+  SequenceNode* ParseConstructorClosure(const Function& func);
 
   void BuildDispatcherScope(const Function& func,
-                            const ArgumentsDescriptor& desc,
-                            ZoneGrowableArray<const Instance*>* default_values);
+                            const ArgumentsDescriptor& desc);
 
   void EnsureHasReturnStatement(SequenceNode* seq, intptr_t return_pos);
   void ChainNewBlock(LocalScope* outer_scope);