content/browser/background_sync/background_sync_service_impl.cc - Issue 1316743002: Reland of [Background Sync] Allow sync manager access from uncontrolled clients

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/background_sync/background_sync_service_impl.cc

Issue 1316743002: Reland of [Background Sync] Allow sync manager access from uncontrolled clients (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/background_sync/background_sync_service_impl.h ('k') | content/browser/background_sync/background_sync_service_impl_unittest.cc » ('j') | content/common/background_sync_service.mojom » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/background_sync/background_sync_service_impl.cc

diff --git a/content/browser/background_sync/background_sync_service_impl.cc b/content/browser/background_sync/background_sync_service_impl.cc

index 7c9507f685a8ee3188ec7d2262d93949c20e2ed8..1a38a4f8fd715911865a597e6041b7e0b6f07d22 100644

--- a/content/browser/background_sync/background_sync_service_impl.cc

+++ b/content/browser/background_sync/background_sync_service_impl.cc

@@ -111,6 +111,7 @@ void BackgroundSyncServiceImpl::OnConnectionError() {

void BackgroundSyncServiceImpl::Register(content::SyncRegistrationPtr options,

int64_t sw_registration_id,

+ bool requested_from_service_worker,

const RegisterCallback& callback) {

DCHECK_CURRENTLY_ON(BrowserThread::IO);

@@ -121,7 +122,7 @@ void BackgroundSyncServiceImpl::Register(content::SyncRegistrationPtr options,

background_sync_context_->background_sync_manager();

DCHECK(background_sync_manager);

background_sync_manager->Register(

- sw_registration_id, mgr_options,

+ sw_registration_id, mgr_options, requested_from_service_worker,

base::Bind(&BackgroundSyncServiceImpl::OnRegisterResult,

weak_ptr_factory_.GetWeakPtr(), callback));

}