Reland of [Background Sync] Allow sync manager access from uncontrolled clients

content/browser/background_sync/background_sync_service_impl_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/background_sync/background_sync_service_impl.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/power_monitor/power_monitor.h"
@@ skipping 162 matching lines @@
     // Create a new BackgroundSyncServiceImpl bound to the dummy channel
     service_impl_.reset(new BackgroundSyncServiceImpl(
         background_sync_context_.get(), service_request.Pass()));
     base::RunLoop().RunUntilIdle();
   }
 
   // Helpers for testing BackgroundSyncServiceImpl methods
   void RegisterOneShot(
       SyncRegistrationPtr sync,
       const BackgroundSyncService::RegisterCallback& callback) {
-    service_impl_->Register(sync.Pass(), sw_registration_id_, callback);
+    service_impl_->Register(sync.Pass(), sw_registration_id_,
+                            true /* requested_from_service_worker */, callback);
     base::RunLoop().RunUntilIdle();
   }
 
+  void RegisterOneShotFromDocument(
+      SyncRegistrationPtr sync,
+      const BackgroundSyncService::RegisterCallback& callback) {
+    service_impl_->Register(sync.Pass(), sw_registration_id_,
+                            false /* requested_from_service_worker */,
+                            callback);
+    base::RunLoop().RunUntilIdle();
+  }
+
   void UnregisterOneShot(
       SyncRegistrationPtr sync,
       const BackgroundSyncService::UnregisterCallback& callback) {
     service_impl_->Unregister(
         BackgroundSyncPeriodicity::BACKGROUND_SYNC_PERIODICITY_ONE_SHOT,
         sync->id, sync->tag, sw_registration_id_, callback);
     base::RunLoop().RunUntilIdle();
   }
 
   void GetRegistrationOneShot(
@@ skipping 45 matching lines @@
   BackgroundSyncError error;
   SyncRegistrationPtr reg;
   RemoveWindowClient();
   RegisterOneShot(
       default_sync_registration_.Clone(),
       base::Bind(&ErrorAndRegistrationCallback, &called, &error, &reg));
   EXPECT_TRUE(called);
   EXPECT_EQ(BackgroundSyncError::BACKGROUND_SYNC_ERROR_NOT_ALLOWED, error);
 }
 
+TEST_F(BackgroundSyncServiceImplTest, RegisterFromControlledClient) {
+  bool called = false;
+  BackgroundSyncError error;
+  SyncRegistrationPtr reg;
+  RegisterOneShotFromDocument(
+      default_sync_registration_.Clone(),
+      base::Bind(&ErrorAndRegistrationCallback, &called, &error, &reg));
+  EXPECT_TRUE(called);
+  EXPECT_EQ(BackgroundSyncError::BACKGROUND_SYNC_ERROR_NONE, error);
+  EXPECT_EQ("", reg->tag);
+}
+
+TEST_F(BackgroundSyncServiceImplTest, RegisterFromUncontrolledClient) {
+  bool called = false;
+  BackgroundSyncError error;
+  SyncRegistrationPtr reg;
+  RemoveWindowClient();
+  RegisterOneShotFromDocument(
+      default_sync_registration_.Clone(),
+      base::Bind(&ErrorAndRegistrationCallback, &called, &error, &reg));
+  EXPECT_TRUE(called);
+  EXPECT_EQ(BackgroundSyncError::BACKGROUND_SYNC_ERROR_NONE, error);
+  EXPECT_EQ("", reg->tag);
+}
+
 TEST_F(BackgroundSyncServiceImplTest, Unregister) {
   bool unregister_called = false;
   BackgroundSyncError unregister_error;
   SyncRegistrationPtr reg;
   UnregisterOneShot(
       default_sync_registration_.Clone(),
       base::Bind(&ErrorCallback, &unregister_called, &unregister_error));
   EXPECT_TRUE(unregister_called);
   EXPECT_EQ(BackgroundSyncError::BACKGROUND_SYNC_ERROR_NOT_FOUND,
             unregister_error);
@@ skipping 73 matching lines @@
   GetRegistrationsOneShot(base::Bind(&ErrorAndRegistrationListCallback,
                                      &getregistrations_called,
                                      &getregistrations_error, &array_size));
   EXPECT_TRUE(getregistrations_called);
   EXPECT_EQ(BackgroundSyncError::BACKGROUND_SYNC_ERROR_NONE,
             getregistrations_error);
   EXPECT_EQ(1UL, array_size);
 }
 
 }  // namespace content