|
|
Chromium Code Reviews
Descriptionmedia/base/cdm_config.h: drop unused #include
BUG=488634
Committed: https://crrev.com/597d8fd4706761687b44cdb03e76c4fdab6359f6
Cr-Commit-Position: refs/heads/master@{#345451}
Patch Set 1 #
Messages
Total messages: 17 (6 generated)
hans@chromium.org changed reviewers: + sandersd@chromium.org, thakis@chromium.org
The Clang problem in crbug.com/488634 is fixed now, so we could undo https://codereview.chromium.org/1133423003/ that removed the MEDIA_EXPORT from this class. But is there a compelling reason to export this class if it's just a simple struct with no methods? Let me know what you think. If we're not exporting it, we can drop the #include.
lgtm, makes sense to me
ddorwin@chromium.org changed reviewers: + ddorwin@chromium.org, xhwang@chromium.org
xhwang, does this need to be exported for Mojo or anything like that?
ddorwin@chromium.org changed reviewers: - ddorwin@chromium.org
On 2015/08/25 17:55:44, ddorwin wrote: > xhwang, does this need to be exported for Mojo or anything like that? We need it in MojoCdmService: https://code.google.com/p/chromium/codesearch#chromium/src/media/mojo/service... But as hans@ pointed out, since this doesn't have any methods, we probably don't need to export it.
The CQ bit was checked by hans@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316733002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
sandersd, xhwang: Can I get an owner's stamp from one of you?
lgtm
The CQ bit was checked by xhwang@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316733002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/597d8fd4706761687b44cdb03e76c4fdab6359f6 Cr-Commit-Position: refs/heads/master@{#345451} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
