Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1316733002: media/base/cdm_config.h: drop unused #include (Closed)

Created:
5 years, 3 months ago by hans
Modified:
5 years, 3 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media/base/cdm_config.h: drop unused #include BUG=488634 Committed: https://crrev.com/597d8fd4706761687b44cdb03e76c4fdab6359f6 Cr-Commit-Position: refs/heads/master@{#345451}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M media/base/cdm_config.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
hans
The Clang problem in crbug.com/488634 is fixed now, so we could undo https://codereview.chromium.org/1133423003/ that removed ...
5 years, 3 months ago (2015-08-25 17:51:49 UTC) #2
Nico
lgtm, makes sense to me
5 years, 3 months ago (2015-08-25 17:55:02 UTC) #3
ddorwin
xhwang, does this need to be exported for Mojo or anything like that?
5 years, 3 months ago (2015-08-25 17:55:44 UTC) #5
xhwang
On 2015/08/25 17:55:44, ddorwin wrote: > xhwang, does this need to be exported for Mojo ...
5 years, 3 months ago (2015-08-25 18:17:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316733002/1
5 years, 3 months ago (2015-08-25 18:27:23 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/92545)
5 years, 3 months ago (2015-08-25 18:38:02 UTC) #11
hans
sandersd, xhwang: Can I get an owner's stamp from one of you?
5 years, 3 months ago (2015-08-25 18:41:51 UTC) #12
xhwang
lgtm
5 years, 3 months ago (2015-08-25 18:56:34 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316733002/1
5 years, 3 months ago (2015-08-25 18:57:49 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-25 22:09:32 UTC) #16
commit-bot: I haz the power
5 years, 3 months ago (2015-08-25 22:10:17 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/597d8fd4706761687b44cdb03e76c4fdab6359f6
Cr-Commit-Position: refs/heads/master@{#345451}

Powered by Google App Engine
This is Rietveld 408576698