Issue 1316643004: Fix typos, nits and remove dead code in fpdf_text_int.cpp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1316643004: Fix typos, nits and remove dead code in fpdf_text_int.cpp. (Closed)

Created:
5 years, 3 months ago by Lei Zhang

Modified:
5 years, 3 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix typos, nits and remove dead code in fpdf_text_int.cpp. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/0bfe588f394e2a00a866d31a30a9d795022f4a6c

Patch Set 1 #

Total comments: 1

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+81 lines, -133 lines)			Patch
M	core/include/fpdftext/fpdf_text.h	View	2 chunks	+5 lines, -7 lines	0 comments	Download
M	core/src/fpdftext/fpdf_text_int.cpp	View	19 chunks	+66 lines, -113 lines	1 comment	Download
M	core/src/fpdftext/text_int.h	View	6 chunks	+10 lines, -13 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Tom Sepez

lgtm https://codereview.chromium.org/1316643004/diff/1/core/src/fpdftext/fpdf_text_int.cpp File core/src/fpdftext/fpdf_text_int.cpp (right): https://codereview.chromium.org/1316643004/diff/1/core/src/fpdftext/fpdf_text_int.cpp#newcode321 core/src/fpdftext/fpdf_text_int.cpp:321: return -3; -3. How intuitive.

5 years, 3 months ago (2015-09-04 16:34:56 UTC) #3

Lei Zhang

5 years, 3 months ago (2015-09-04 21:11:11 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0bfe588f394e2a00a866d31a30a9d795022f4a6c (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages