Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1316643004: Fix typos, nits and remove dead code in fpdf_text_int.cpp. (Closed)

Created:
5 years, 3 months ago by Lei Zhang
Modified:
5 years, 3 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix typos, nits and remove dead code in fpdf_text_int.cpp. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/0bfe588f394e2a00a866d31a30a9d795022f4a6c

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -133 lines) Patch
M core/include/fpdftext/fpdf_text.h View 2 chunks +5 lines, -7 lines 0 comments Download
M core/src/fpdftext/fpdf_text_int.cpp View 19 chunks +66 lines, -113 lines 1 comment Download
M core/src/fpdftext/text_int.h View 6 chunks +10 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Lei Zhang
5 years, 3 months ago (2015-09-04 07:42:30 UTC) #2
Tom Sepez
lgtm https://codereview.chromium.org/1316643004/diff/1/core/src/fpdftext/fpdf_text_int.cpp File core/src/fpdftext/fpdf_text_int.cpp (right): https://codereview.chromium.org/1316643004/diff/1/core/src/fpdftext/fpdf_text_int.cpp#newcode321 core/src/fpdftext/fpdf_text_int.cpp:321: return -3; -3. How intuitive.
5 years, 3 months ago (2015-09-04 16:34:56 UTC) #3
Lei Zhang
5 years, 3 months ago (2015-09-04 21:11:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0bfe588f394e2a00a866d31a30a9d795022f4a6c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698