Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 1316633002: Fix AstExpressionVisitor to correctly handle switch + for. (Closed)

Created:
5 years, 4 months ago by bradn
Modified:
5 years, 4 months ago
Reviewers:
titzer, rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix AstExpressionVisitor to correctly handle switch + for. These were missed by the previous tests, uncovered in another context. BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=test-ast-expression-visitor R=rossberg@chromium.org,titzer@chromium.org LOG=N Committed: https://crrev.com/09b54808b1bdfac9c4dea93796ed8c2a7ffe2f9b Cr-Commit-Position: refs/heads/master@{#30360}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -5 lines) Patch
M src/ast-expression-visitor.cc View 1 2 chunks +13 lines, -5 lines 0 comments Download
M test/cctest/test-ast-expression-visitor.cc View 1 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
bradn
5 years, 4 months ago (2015-08-25 05:57:56 UTC) #1
rossberg
https://codereview.chromium.org/1316633002/diff/1/src/ast-expression-visitor.cc File src/ast-expression-visitor.cc (right): https://codereview.chromium.org/1316633002/diff/1/src/ast-expression-visitor.cc#newcode116 src/ast-expression-visitor.cc:116: VisitExpression(label); Why is the label visited twice?
5 years, 4 months ago (2015-08-25 06:33:34 UTC) #2
bradn
PTAL https://codereview.chromium.org/1316633002/diff/1/src/ast-expression-visitor.cc File src/ast-expression-visitor.cc (right): https://codereview.chromium.org/1316633002/diff/1/src/ast-expression-visitor.cc#newcode116 src/ast-expression-visitor.cc:116: VisitExpression(label); On 2015/08/25 06:33:33, rossberg wrote: > Why ...
5 years, 4 months ago (2015-08-25 07:40:19 UTC) #3
rossberg
lgtm
5 years, 4 months ago (2015-08-25 08:01:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316633002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316633002/20001
5 years, 4 months ago (2015-08-25 16:05:41 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-25 16:07:19 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-25 16:07:37 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/09b54808b1bdfac9c4dea93796ed8c2a7ffe2f9b
Cr-Commit-Position: refs/heads/master@{#30360}

Powered by Google App Engine
This is Rietveld 408576698