Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issue 131663003: Make the strict-mode calling convention for contextual calls the default one. (Closed)

Created:
6 years, 11 months ago by Toon Verwaest
Modified:
6 years, 11 months ago
Reviewers:
dcarney, rossberg
CC:
v8-dev
Visibility:
Public.

Description

Make the strict-mode calling convention for contextual calls the default one. BUG= R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18581

Patch Set 1 : #

Total comments: 6

Patch Set 2 : Addressed comments #

Patch Set 3 : Update comments #

Patch Set 4 : Port to X64 #

Patch Set 5 : ARM port #

Patch Set 6 : Fix arm port #

Unified diffs Side-by-side diffs Delta from patch set Stats (+314 lines, -536 lines) Patch
M src/arm/builtins-arm.cc View 1 2 3 4 6 chunks +6 lines, -9 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 2 3 4 3 chunks +4 lines, -49 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 1 2 3 4 5 5 chunks +24 lines, -17 lines 0 comments Download
M src/arm/ic-arm.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/arm/lithium-arm.cc View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 2 3 4 6 chunks +31 lines, -17 lines 0 comments Download
M src/arm/stub-cache-arm.cc View 1 2 3 4 3 chunks +3 lines, -24 lines 0 comments Download
M src/builtins.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
M src/code-stubs.h View 1 2 chunks +2 lines, -10 lines 0 comments Download
M src/code-stubs.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler.h View 2 chunks +9 lines, -0 lines 0 comments Download
M src/compiler.cc View 5 chunks +9 lines, -4 lines 0 comments Download
M src/hydrogen.h View 1 3 chunks +4 lines, -13 lines 0 comments Download
M src/hydrogen.cc View 1 10 chunks +36 lines, -45 lines 0 comments Download
M src/hydrogen-instructions.h View 5 chunks +2 lines, -7 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 7 chunks +14 lines, -13 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 3 chunks +4 lines, -49 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 5 chunks +20 lines, -19 lines 0 comments Download
M src/ia32/ic-ia32.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 7 chunks +29 lines, -21 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 3 chunks +4 lines, -25 lines 0 comments Download
M src/runtime.cc View 1 2 5 chunks +14 lines, -15 lines 0 comments Download
M src/stub-cache.h View 1 chunk +3 lines, -7 lines 0 comments Download
M src/stub-cache.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/v8globals.h View 1 1 chunk +2 lines, -7 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 2 3 6 chunks +13 lines, -11 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 3 3 chunks +4 lines, -48 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 2 3 4 5 chunks +23 lines, -17 lines 0 comments Download
M src/x64/ic-x64.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 2 3 6 chunks +26 lines, -19 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 1 2 3 3 chunks +3 lines, -23 lines 0 comments Download
D test/mjsunit/bugs/bug-2758.js View 1 chunk +0 lines, -49 lines 0 comments Download
M test/mjsunit/harmony/generators-iteration.js View 1 chunk +4 lines, -3 lines 0 comments Download
M test/mjsunit/harmony/object-observe.js View 1 chunk +2 lines, -1 line 0 comments Download
M test/mjsunit/harmony/proxies-function.js View 1 chunk +2 lines, -2 lines 0 comments Download
A + test/mjsunit/regress/regress-2758.js View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Toon Verwaest
dcarney@ PTAL rossberg@ FYI
6 years, 11 months ago (2014-01-13 17:45:55 UTC) #1
dcarney
https://codereview.chromium.org/131663003/diff/330001/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/131663003/diff/330001/src/hydrogen.cc#newcode7798 src/hydrogen.cc:7798: if (shared->is_classic_mode() && !shared->native()) { not really for this ...
6 years, 11 months ago (2014-01-13 18:35:02 UTC) #2
dcarney
lgtm
6 years, 11 months ago (2014-01-14 10:27:50 UTC) #3
dcarney
lgtm, again
6 years, 11 months ago (2014-01-14 11:56:53 UTC) #4
Toon Verwaest
6 years, 11 months ago (2014-01-14 12:05:06 UTC) #5
Message was sent while issue was closed.
Committed patchset #6 manually as r18581 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698