Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1316603002: Make DragController to use VisibleSelection::toNormalizedEphemeralRange() instead of toNormalizedRan (Closed)

Created:
5 years, 4 months ago by yosin_UTC9
Modified:
5 years, 4 months ago
Reviewers:
tkent
CC:
blink-reviews, dcheng, yoichio
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make DragController to use VisibleSelection::toNormalizedEphemeralRange() instead of toNormalizedRange() This patch changes |DragController| class to use |toNormalizedEphemeralRange()| in |VisibleSelection| class instead of |toNormalizedRange()| as a preparation of templatizing |VisibleSelection| to use templatized positions instead of DOM position to represent range. This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1277863002 BUG=513568 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201115

Patch Set 1 : 2015-08-25T14:37:36 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/core/page/DragController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
yosin_UTC9
PTAL
5 years, 4 months ago (2015-08-25 06:01:02 UTC) #2
tkent
lgtm
5 years, 4 months ago (2015-08-25 06:03:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316603002/1
5 years, 4 months ago (2015-08-25 06:14:38 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/103627)
5 years, 4 months ago (2015-08-25 06:56:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316603002/1
5 years, 4 months ago (2015-08-25 07:41:14 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-25 09:32:03 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201115

Powered by Google App Engine
This is Rietveld 408576698