Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 1316583003: X87: [Interpreter] Pass context to interpreter bytecode handlers and add LoadConstextSlot (Closed)

Created:
5 years, 3 months ago by chunyang.dai
Modified:
5 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [Interpreter] Pass context to interpreter bytecode handlers and add LoadConstextSlot For X87 platform, it has the same general register as ia32 and it will spill the context to the stack too. port bfdc22d7fc1bc046a38770a676619eee613222f3 (r29325). original commit message: Passes the current context to bytecode interpreter handlers. This is held in the context register on all architectures except for ia32 where there are too few registers and it is instead spilled to the stack. Also changes Load/StoreRegister to use kMachAnyTagged representation since they should only ever hold tagged values. BUG= Committed: https://crrev.com/b5911513ccb137307f14844ac202fcc905a3087e Cr-Commit-Position: refs/heads/master@{#30368}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M src/compiler/linkage.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/builtins-x87.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/x87/macro-assembler-x87.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL.
5 years, 3 months ago (2015-08-25 07:54:40 UTC) #2
Michael Starzinger
LGTM.
5 years, 3 months ago (2015-08-25 17:33:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316583003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316583003/1
5 years, 3 months ago (2015-08-26 00:38:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-26 01:17:14 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-08-26 01:17:23 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b5911513ccb137307f14844ac202fcc905a3087e
Cr-Commit-Position: refs/heads/master@{#30368}

Powered by Google App Engine
This is Rietveld 408576698