[Aura] Drop to WebContentsView sets wrong drop effect.

[Aura] Drop to WebContentsView sets wrong drop effect.

Types mismatch causes setting wrong DROPEFFECT (move swapped with copy) on Windows.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244500

[Ben Goodger (Google), 2014-01-09 22:56:38]

lgtm


On Thu, Jan 9, 2014 at 4:27 AM, <mmaliszkiewicz@opera.com> wrote:

> Reviewers: Ben Goodger (Google),
>
> Description:
> [Aura] Drop to WebContentsView sets wrong drop effect.
>
> Types mismatch causes setting wrong DROPEFFECT (move swapped with copy) on
> Windows.
>
> Please review this at https://codereview.chromium.org/131653002/
>
> SVN Base: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+1, -1 lines):
>   M content/browser/web_contents/web_contents_view_aura.cc
>
>
> Index: content/browser/web_contents/web_contents_view_aura.cc
> diff --git a/content/browser/web_contents/web_contents_view_aura.cc
> b/content/browser/web_contents/web_contents_view_aura.cc
> index e4ef8c0f559455bbfdf3039cdfd5d6aae1122b9b..
> a638e6da70e60100996eaa501b4ae73e62b6af12 100644
> --- a/content/browser/web_contents/web_contents_view_aura.cc
> +++ b/content/browser/web_contents/web_contents_view_aura.cc
> @@ -1725,7 +1725,7 @@ int WebContentsViewAura::OnPerformDrop(const
> ui::DropTargetEvent& event) {
>    if (drag_dest_delegate_)
>      drag_dest_delegate_->OnDrop();
>    current_drop_data_.reset();
> -  return current_drag_op_;
> +  return ConvertFromWeb(current_drag_op_);
>  }
>
>  }  // namespace content
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2014-01-10 12:38:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mmaliszkiewicz@opera.com/131653002/1

[commit-bot: I haz the power, 2014-01-10 13:36:58]

Retried try job too often on linux_rel for step(s) check_deps2git
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2014-01-13 13:14:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mmaliszkiewicz@opera.com/131653002/1

[commit-bot: I haz the power, 2014-01-13 14:25:57]

Change committed as 244500