Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 13165011: Add tile rendering to GM (Closed)

Created:
7 years, 8 months ago by robertphillips
Modified:
7 years, 8 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com, junov1
Visibility:
Public.

Description

This change is necessary to reproducing the SkPictureRecord/impl-side painting bug (it is the re-rendering of the same picture at multiple locations that triggers the bug). It cannot be enabled yet due several rendering issues but I would like to deliver it so others can experiment and debug.

Patch Set 1 #

Total comments: 4

Patch Set 2 : replaced bitmap_copy_subset with canvas drawBitmap #

Patch Set 3 : fixed typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -7 lines) Patch
M gm/gmmain.cpp View 1 2 2 chunks +48 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
robertphillips
7 years, 8 months ago (2013-04-01 17:11:27 UTC) #1
bsalomon
https://codereview.chromium.org/13165011/diff/1/gm/gmmain.cpp File gm/gmmain.cpp (right): https://codereview.chromium.org/13165011/diff/1/gm/gmmain.cpp#newcode453 gm/gmmain.cpp:453: bitmap_copy_subset(tileBM, bitmap, Maybe create an SkCanvas around bitmap and ...
7 years, 8 months ago (2013-04-01 17:36:43 UTC) #2
robertphillips
https://codereview.chromium.org/13165011/diff/1/gm/gmmain.cpp File gm/gmmain.cpp (right): https://codereview.chromium.org/13165011/diff/1/gm/gmmain.cpp#newcode453 gm/gmmain.cpp:453: bitmap_copy_subset(tileBM, bitmap, What does that buy us?
7 years, 8 months ago (2013-04-01 18:21:51 UTC) #3
bsalomon
https://codereview.chromium.org/13165011/diff/1/gm/gmmain.cpp File gm/gmmain.cpp (right): https://codereview.chromium.org/13165011/diff/1/gm/gmmain.cpp#newcode453 gm/gmmain.cpp:453: bitmap_copy_subset(tileBM, bitmap, On 2013/04/01 18:21:52, robertphillips wrote: > What ...
7 years, 8 months ago (2013-04-01 18:28:25 UTC) #4
robertphillips
https://codereview.chromium.org/13165011/diff/1/gm/gmmain.cpp File gm/gmmain.cpp (right): https://codereview.chromium.org/13165011/diff/1/gm/gmmain.cpp#newcode453 gm/gmmain.cpp:453: bitmap_copy_subset(tileBM, bitmap, On 2013/04/01 18:28:27, bsalomon wrote: > On ...
7 years, 8 months ago (2013-04-02 13:29:53 UTC) #5
bsalomon
On 2013/04/02 13:29:53, robertphillips wrote: > https://codereview.chromium.org/13165011/diff/1/gm/gmmain.cpp > File gm/gmmain.cpp (right): > > https://codereview.chromium.org/13165011/diff/1/gm/gmmain.cpp#newcode453 > ...
7 years, 8 months ago (2013-04-02 14:49:04 UTC) #6
robertphillips
7 years, 8 months ago (2013-04-02 15:19:00 UTC) #7
Message was sent while issue was closed.
committed as r8485

Powered by Google App Engine
This is Rietveld 408576698