Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1316443006: Write a gm to verify append large glyph as path works (Closed)

Created:
5 years, 3 months ago by joshua.litt
Modified:
5 years, 3 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Write a gm to verify append large glyph as path works BUG=chromium:522846 Committed: https://skia.googlesource.com/skia/+/e46cf96ef5781ac40852bbf4f489bc47e2a2485e

Patch Set 1 #

Total comments: 5

Patch Set 2 : feedback inc #

Patch Set 3 : windows warnings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -0 lines) Patch
A gm/textblobmixedsizes.cpp View 1 2 1 chunk +191 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
joshualitt
ptal, this requires Ben's funny font to work
5 years, 3 months ago (2015-08-26 17:18:07 UTC) #2
robertphillips
lgtm + questions https://codereview.chromium.org/1316443006/diff/1/gm/textblobmixedsizes.cpp File gm/textblobmixedsizes.cpp (right): https://codereview.chromium.org/1316443006/diff/1/gm/textblobmixedsizes.cpp#newcode57 gm/textblobmixedsizes.cpp:57: paint.setTextSize(72); add line ? https://codereview.chromium.org/1316443006/diff/1/gm/textblobmixedsizes.cpp#newcode63 gm/textblobmixedsizes.cpp:63: ...
5 years, 3 months ago (2015-08-26 17:33:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316443006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316443006/20001
5 years, 3 months ago (2015-08-26 18:08:58 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/2890)
5 years, 3 months ago (2015-08-26 18:12:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316443006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316443006/40001
5 years, 3 months ago (2015-08-26 18:14:12 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-08-26 18:19:58 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/e46cf96ef5781ac40852bbf4f489bc47e2a2485e

Powered by Google App Engine
This is Rietveld 408576698