Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1316443002: Call `gzip` in subprocess instead of gzipping in Python in http_server. (Closed)

Created:
5 years, 4 months ago by ppi
Modified:
5 years, 4 months ago
Reviewers:
piotrt, etiennej
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Call `gzip` in subprocess instead of gzipping in Python in http_server. Before: ``` $ time wget http://127.0.0.1:59993/spinning_cube.mojo (...) real 0m3.987s user 0m0.001s sys 0m0.017s ``` After: ``` $ time wget http://127.0.0.1:55035/spinning_cube.mojo (...) real 0m1.226s user 0m0.004s sys 0m0.014s ``` Fixes domokit/devtools#35. R=piotrt@google.com Committed: https://chromium.googlesource.com/external/mojo/+/c1d55465d7c2ce8717b59677d08b430344c31dbd

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address Piotr's comments. #

Total comments: 2

Patch Set 3 : Address Piotr's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -26 lines) Patch
M mojo/devtools/common/devtoolslib/http_server.py View 1 2 6 chunks +40 lines, -25 lines 0 comments Download
M mojo/devtools/common/devtoolslib/shell_arguments.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
ppi
Hi Etienne, ptal.
5 years, 4 months ago (2015-08-24 16:38:27 UTC) #3
ppi
Hi Etienne or Piotr, ptal.
5 years, 4 months ago (2015-08-25 09:12:41 UTC) #5
piotrt
https://codereview.chromium.org/1316443002/diff/1/mojo/devtools/common/devtoolslib/http_server.py File mojo/devtools/common/devtoolslib/http_server.py (right): https://codereview.chromium.org/1316443002/diff/1/mojo/devtools/common/devtoolslib/http_server.py#newcode157 mojo/devtools/common/devtoolslib/http_server.py:157: subprocess.check_call(['gzip', '-c', candidate], Maybe it would be good to ...
5 years, 4 months ago (2015-08-25 09:23:36 UTC) #6
ppi
https://codereview.chromium.org/1316443002/diff/1/mojo/devtools/common/devtoolslib/http_server.py File mojo/devtools/common/devtoolslib/http_server.py (right): https://codereview.chromium.org/1316443002/diff/1/mojo/devtools/common/devtoolslib/http_server.py#newcode157 mojo/devtools/common/devtoolslib/http_server.py:157: subprocess.check_call(['gzip', '-c', candidate], On 2015/08/25 09:23:36, piotrt wrote: > ...
5 years, 4 months ago (2015-08-25 11:34:36 UTC) #7
piotrt
lgtm with an optional minor comment :) https://codereview.chromium.org/1316443002/diff/20001/mojo/devtools/common/devtoolslib/http_server.py File mojo/devtools/common/devtoolslib/http_server.py (right): https://codereview.chromium.org/1316443002/diff/20001/mojo/devtools/common/devtoolslib/http_server.py#newcode157 mojo/devtools/common/devtoolslib/http_server.py:157: self.gzipped_file = ...
5 years, 4 months ago (2015-08-25 11:55:23 UTC) #8
ppi
https://codereview.chromium.org/1316443002/diff/20001/mojo/devtools/common/devtoolslib/http_server.py File mojo/devtools/common/devtoolslib/http_server.py (right): https://codereview.chromium.org/1316443002/diff/20001/mojo/devtools/common/devtoolslib/http_server.py#newcode157 mojo/devtools/common/devtoolslib/http_server.py:157: self.gzipped_file = tempfile.NamedTemporaryFile(delete=False) On 2015/08/25 11:55:23, piotrt wrote: > ...
5 years, 4 months ago (2015-08-25 12:07:43 UTC) #9
ppi
5 years, 4 months ago (2015-08-25 12:09:04 UTC) #10
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
c1d55465d7c2ce8717b59677d08b430344c31dbd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698