Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 131643003: Move third_party/html_office to chrome/browser/resources/pdf (Closed)

Created:
6 years, 11 months ago by raymes
Modified:
6 years, 11 months ago
Reviewers:
cmp, ganetsky1
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Move third_party/html_office to chrome/browser/resources/pdf This moves third_party/html_office to chrome/browser/resources/pdf. Currently html_office is only used by the pdf component extension, it isn't third_party code and it's more difficult to use the code from it's current location. The repo is also still empty so this shouldn't result in a lot of dwarf files. BUG=303491 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245442

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M .gitignore View 2 chunks +1 line, -1 line 0 comments Download
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
raymes
Hey guys ptal. The other location won't work for including the elements in an extension. ...
6 years, 11 months ago (2014-01-16 05:21:06 UTC) #1
cmp
lgtm Should be fine.
6 years, 11 months ago (2014-01-16 19:47:08 UTC) #2
ganetsky1
lgtm
6 years, 11 months ago (2014-01-16 23:12:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/131643003/30001
6 years, 11 months ago (2014-01-16 23:28:31 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-17 06:41:27 UTC) #5
Message was sent while issue was closed.
Change committed as 245442

Powered by Google App Engine
This is Rietveld 408576698