Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Side by Side Diff: build/android/PRESUBMIT.py

Issue 1316413003: [Android] Add a configurable environment for devil/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/android/buildbot/bb_device_status_check.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Presubmit script for android buildbot. 5 """Presubmit script for android buildbot.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for
8 details on the presubmit API built into depot_tools. 8 details on the presubmit API built into depot_tools.
9 """ 9 """
10 10
11 11
12 def CommonChecks(input_api, output_api): 12 def CommonChecks(input_api, output_api):
13 output = [] 13 output = []
14 14
15 build_android_dir = input_api.PresubmitLocalPath()
16 chromium_src_dir = input_api.os_path.join(build_android_dir, '..', '..')
17
15 def J(*dirs): 18 def J(*dirs):
16 """Returns a path relative to presubmit directory.""" 19 """Returns a path relative to presubmit directory."""
17 return input_api.os_path.join(input_api.PresubmitLocalPath(), *dirs) 20 return input_api.os_path.join(build_android_dir, *dirs)
18 21
19 build_pys = [ 22 build_pys = [
20 r'gyp/.*\.py$', 23 r'gyp/.*\.py$',
21 r'gn/.*\.py', 24 r'gn/.*\.py',
22 r'incremental_install/.*\.py', 25 r'incremental_install/.*\.py',
23 ] 26 ]
24 output.extend(input_api.canned_checks.RunPylint( 27 output.extend(input_api.canned_checks.RunPylint(
25 input_api, 28 input_api,
26 output_api, 29 output_api,
27 pylintrc='pylintrc', 30 pylintrc='pylintrc',
28 # symbols has its own PRESUBMIT.py 31 # symbols has its own PRESUBMIT.py
29 black_list=build_pys + [r'pylib/symbols/.*\.py$'], 32 black_list=build_pys + [r'pylib/symbols/.*\.py$'],
30 extra_paths_list=[J(), J('buildbot')])) 33 extra_paths_list=[J(), J('buildbot')]))
31 output.extend(input_api.canned_checks.RunPylint( 34 output.extend(input_api.canned_checks.RunPylint(
32 input_api, 35 input_api,
33 output_api, 36 output_api,
34 white_list=build_pys, 37 white_list=build_pys,
35 extra_paths_list=[J('gyp'), J('gn')])) 38 extra_paths_list=[J('gyp'), J('gn')]))
36 39
37 # Disabled due to http://crbug.com/410936 40 # Disabled due to http://crbug.com/410936
38 #output.extend(input_api.canned_checks.RunUnitTestsInDirectory( 41 #output.extend(input_api.canned_checks.RunUnitTestsInDirectory(
39 #input_api, output_api, J('buildbot', 'tests'))) 42 #input_api, output_api, J('buildbot', 'tests')))
40 43
41 pylib_test_env = dict(input_api.environ) 44 pylib_test_env = dict(input_api.environ)
42 pylib_test_env.update({ 45 pylib_test_env.update({
43 'PYTHONPATH': input_api.PresubmitLocalPath(), 46 'PYTHONPATH': build_android_dir,
44 'PYTHONDONTWRITEBYTECODE': '1', 47 'PYTHONDONTWRITEBYTECODE': '1',
45 }) 48 })
46 output.extend(input_api.canned_checks.RunUnitTests( 49 output.extend(input_api.canned_checks.RunUnitTests(
47 input_api, 50 input_api,
48 output_api, 51 output_api,
49 unit_tests=[ 52 unit_tests=[
50 J('.', 'emma_coverage_stats_test.py'), 53 J('.', 'emma_coverage_stats_test.py'),
51 J('devil', 'android', 'battery_utils_test.py'),
52 J('devil', 'android', 'device_utils_test.py'),
53 J('devil', 'android', 'md5sum_test.py'),
54 J('devil', 'android', 'logcat_monitor_test.py'),
55 J('devil', 'utils', 'timeout_retry_unittest.py'),
56 J('gyp', 'util', 'md5_check_test.py'), 54 J('gyp', 'util', 'md5_check_test.py'),
57 J('pylib', 'base', 'test_dispatcher_unittest.py'), 55 J('pylib', 'base', 'test_dispatcher_unittest.py'),
58 J('pylib', 'gtest', 'gtest_test_instance_test.py'), 56 J('pylib', 'gtest', 'gtest_test_instance_test.py'),
59 J('pylib', 'instrumentation', 57 J('pylib', 'instrumentation',
60 'instrumentation_test_instance_test.py'), 58 'instrumentation_test_instance_test.py'),
61 J('pylib', 'results', 'json_results_test.py'), 59 J('pylib', 'results', 'json_results_test.py'),
62 ], 60 ],
63 env=pylib_test_env)) 61 env=pylib_test_env))
62
63
64 devil_test_env = dict(pylib_test_env)
65 devil_test_env.update({
66 'DEVIL_BINARY_DIR':
67 input_api.os_path.join(chromium_src_dir, 'output', 'directory'),
68 'DEVIL_PYMOCK_PATH':
69 input_api.os_path.join(chromium_src_dir, 'third_party', 'pymock')
70 })
71 output.extend(input_api.canned_checks.RunUnitTests(
72 input_api,
73 output_api,
74 unit_tests=[
75 J('devil', 'android', 'battery_utils_test.py'),
76 J('devil', 'android', 'device_utils_test.py'),
77 J('devil', 'android', 'md5sum_test.py'),
78 J('devil', 'android', 'logcat_monitor_test.py'),
79 J('devil', 'utils', 'timeout_retry_unittest.py'),
80 ],
81 env=devil_test_env))
64 return output 82 return output
65 83
66 84
67 def CheckChangeOnUpload(input_api, output_api): 85 def CheckChangeOnUpload(input_api, output_api):
68 return CommonChecks(input_api, output_api) 86 return CommonChecks(input_api, output_api)
69 87
70 88
71 def CheckChangeOnCommit(input_api, output_api): 89 def CheckChangeOnCommit(input_api, output_api):
72 return CommonChecks(input_api, output_api) 90 return CommonChecks(input_api, output_api)
OLDNEW
« no previous file with comments | « no previous file | build/android/buildbot/bb_device_status_check.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698