OLD | NEW |
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. |
2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
4 | 4 |
5 """Presubmit script for android buildbot. | 5 """Presubmit script for android buildbot. |
6 | 6 |
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for |
8 details on the presubmit API built into depot_tools. | 8 details on the presubmit API built into depot_tools. |
9 """ | 9 """ |
10 | 10 |
11 | 11 |
12 def CommonChecks(input_api, output_api): | 12 def CommonChecks(input_api, output_api): |
13 output = [] | 13 output = [] |
14 | 14 |
| 15 build_android_dir = input_api.PresubmitLocalPath() |
| 16 chromium_src_dir = input_api.os_path.join(build_android_dir, '..', '..') |
| 17 |
15 def J(*dirs): | 18 def J(*dirs): |
16 """Returns a path relative to presubmit directory.""" | 19 """Returns a path relative to presubmit directory.""" |
17 return input_api.os_path.join(input_api.PresubmitLocalPath(), *dirs) | 20 return input_api.os_path.join(build_android_dir, *dirs) |
18 | 21 |
19 output.extend(input_api.canned_checks.RunPylint( | 22 output.extend(input_api.canned_checks.RunPylint( |
20 input_api, | 23 input_api, |
21 output_api, | 24 output_api, |
22 pylintrc='pylintrc', | 25 pylintrc='pylintrc', |
23 black_list=[r'pylib/symbols/.*\.py$', r'gyp/.*\.py$', r'gn/.*\.py'], | 26 black_list=[r'pylib/symbols/.*\.py$', r'gyp/.*\.py$', r'gn/.*\.py'], |
24 extra_paths_list=[J(), J('buildbot')])) | 27 extra_paths_list=[J(), J('buildbot')])) |
25 output.extend(input_api.canned_checks.RunPylint( | 28 output.extend(input_api.canned_checks.RunPylint( |
26 input_api, | 29 input_api, |
27 output_api, | 30 output_api, |
28 white_list=[r'gyp/.*\.py$', r'gn/.*\.py'], | 31 white_list=[r'gyp/.*\.py$', r'gn/.*\.py'], |
29 extra_paths_list=[J('gyp'), J('gn')])) | 32 extra_paths_list=[J('gyp'), J('gn')])) |
30 | 33 |
31 # Disabled due to http://crbug.com/410936 | 34 # Disabled due to http://crbug.com/410936 |
32 #output.extend(input_api.canned_checks.RunUnitTestsInDirectory( | 35 #output.extend(input_api.canned_checks.RunUnitTestsInDirectory( |
33 #input_api, output_api, J('buildbot', 'tests'))) | 36 #input_api, output_api, J('buildbot', 'tests'))) |
34 | 37 |
35 pylib_test_env = dict(input_api.environ) | 38 pylib_test_env = dict(input_api.environ) |
36 pylib_test_env.update({ | 39 pylib_test_env.update({ |
37 'PYTHONPATH': input_api.PresubmitLocalPath(), | 40 'PYTHONPATH': build_android_dir, |
38 'PYTHONDONTWRITEBYTECODE': '1', | 41 'PYTHONDONTWRITEBYTECODE': '1', |
39 }) | 42 }) |
40 output.extend(input_api.canned_checks.RunUnitTests( | 43 output.extend(input_api.canned_checks.RunUnitTests( |
41 input_api, | 44 input_api, |
42 output_api, | 45 output_api, |
43 unit_tests=[ | 46 unit_tests=[ |
44 J('.', 'emma_coverage_stats_test.py'), | 47 J('.', 'emma_coverage_stats_test.py'), |
45 J('devil', 'android', 'battery_utils_test.py'), | |
46 J('devil', 'android', 'device_utils_test.py'), | |
47 J('devil', 'android', 'md5sum_test.py'), | |
48 J('devil', 'android', 'logcat_monitor_test.py'), | |
49 J('pylib', 'base', 'test_dispatcher_unittest.py'), | 48 J('pylib', 'base', 'test_dispatcher_unittest.py'), |
50 J('pylib', 'gtest', 'gtest_test_instance_test.py'), | 49 J('pylib', 'gtest', 'gtest_test_instance_test.py'), |
51 J('pylib', 'instrumentation', | 50 J('pylib', 'instrumentation', |
52 'instrumentation_test_instance_test.py'), | 51 'instrumentation_test_instance_test.py'), |
53 J('pylib', 'results', 'json_results_test.py'), | 52 J('pylib', 'results', 'json_results_test.py'), |
54 ], | 53 ], |
55 env=pylib_test_env)) | 54 env=pylib_test_env)) |
| 55 |
| 56 |
| 57 devil_test_env = dict(pylib_test_env) |
| 58 devil_test_env.update({ |
| 59 'DEVIL_BINARY_DIR': |
| 60 input_api.os_path.join(chromium_src_dir, 'output', 'directory'), |
| 61 'DEVIL_PYMOCK_PATH': |
| 62 input_api.os_path.join(chromium_src_dir, 'third_party', 'pymock') |
| 63 }) |
| 64 output.extend(input_api.canned_checks.RunUnitTests( |
| 65 input_api, |
| 66 output_api, |
| 67 unit_tests=[ |
| 68 J('devil', 'android', 'battery_utils_test.py'), |
| 69 J('devil', 'android', 'device_utils_test.py'), |
| 70 J('devil', 'android', 'md5sum_test.py'), |
| 71 J('devil', 'android', 'logcat_monitor_test.py'), |
| 72 ], |
| 73 env=devil_test_env)) |
56 return output | 74 return output |
57 | 75 |
58 | 76 |
59 def CheckChangeOnUpload(input_api, output_api): | 77 def CheckChangeOnUpload(input_api, output_api): |
60 return CommonChecks(input_api, output_api) | 78 return CommonChecks(input_api, output_api) |
61 | 79 |
62 | 80 |
63 def CheckChangeOnCommit(input_api, output_api): | 81 def CheckChangeOnCommit(input_api, output_api): |
64 return CommonChecks(input_api, output_api) | 82 return CommonChecks(input_api, output_api) |
OLD | NEW |