Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 1316403005: view-manager: Use --override-use-gl-with-osmesa-for-tests for apptests on non-android. (Closed)

Created:
5 years, 3 months ago by sadrul
Modified:
5 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

view-manager: Use --override-use-gl-with-osmesa-for-tests for apptests on non-android. BUG=523144 Committed: https://crrev.com/4908a5b6d3611d314b0cfd0ea5dc965e962f1d71 Cr-Commit-Position: refs/heads/master@{#347113}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M mojo/tools/data/apptests View 1 2 2 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
sadrul
5 years, 3 months ago (2015-09-02 22:57:17 UTC) #2
sky
LGTM https://codereview.chromium.org/1316403005/diff/20001/mojo/tools/data/apptests File mojo/tools/data/apptests (right): https://codereview.chromium.org/1316403005/diff/20001/mojo/tools/data/apptests#newcode25 mojo/tools/data/apptests:25: if config.target_os != config.OS_ANDROID: It's worth a comment ...
5 years, 3 months ago (2015-09-02 23:02:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316403005/10002 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316403005/10002
5 years, 3 months ago (2015-09-03 04:01:54 UTC) #6
sadrul
https://codereview.chromium.org/1316403005/diff/20001/mojo/tools/data/apptests File mojo/tools/data/apptests (right): https://codereview.chromium.org/1316403005/diff/20001/mojo/tools/data/apptests#newcode25 mojo/tools/data/apptests:25: if config.target_os != config.OS_ANDROID: On 2015/09/02 23:02:08, sky wrote: ...
5 years, 3 months ago (2015-09-03 04:02:56 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:10002)
5 years, 3 months ago (2015-09-03 05:13:00 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-03 05:13:46 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4908a5b6d3611d314b0cfd0ea5dc965e962f1d71
Cr-Commit-Position: refs/heads/master@{#347113}

Powered by Google App Engine
This is Rietveld 408576698