Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 1316403004: Ensure that we trigger deferred frame commits. (Closed)

Created:
5 years, 3 months ago by rune
Modified:
5 years, 3 months ago
Reviewers:
esprehn
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Schedule a BeginFrame when we stop deferring commits. We do not scheduleVisualUpdate for setNeedsStyleRecalc when we have pending stylesheets. If we setNeedsStyleRecalc while loading a stylesheet, we won't necessarily trigger a BeginFrame when the stylesheet finishes loading because subsequent setNeedsStyleRecalc call won't trigger those either if the ascendants are already marked with childNeedsStyleRecalc because we assume the visual update is already scheduled. Schedule a BeginFrame from resumeTreeViewCommits to make sure deferred visual updates are triggered. BUG=384934 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201933

Patch Set 1 #

Patch Set 2 : Typo fix #

Patch Set 3 : Trigger BeginFrame from resumeTreeViewCommits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -1 line) Patch
M Source/web/WebViewImpl.cpp View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M Source/web/tests/DocumentLoadingRenderingTest.cpp View 1 2 3 chunks +40 lines, -0 lines 0 comments Download
M Source/web/tests/sim/SimLayerTreeView.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
rune
Ideas for how to make the test more reliable are welcome.
5 years, 3 months ago (2015-08-31 22:44:06 UTC) #1
esprehn
Look at the new DocumentLoadingRenderingTest, you want to write one of those. I don't think ...
5 years, 3 months ago (2015-08-31 23:32:10 UTC) #2
rune
On 2015/08/31 23:32:10, esprehn wrote: > Look at the new DocumentLoadingRenderingTest, you want to write ...
5 years, 3 months ago (2015-09-08 09:31:41 UTC) #3
esprehn
lgtm
5 years, 3 months ago (2015-09-08 20:37:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316403004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316403004/40001
5 years, 3 months ago (2015-09-08 20:44:47 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-08 21:48:57 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201933

Powered by Google App Engine
This is Rietveld 408576698