Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 1316323002: Remove redundant DocumentLoadTiming references. (Closed)

Created:
5 years, 3 months ago by sof
Modified:
5 years, 3 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove redundant DocumentLoadTiming references. Having ScriptedIdleTaskController and its auxillary object keep a reference to a document's DocumentLoadTiming part object is unnecessary as the deadlines do not have to be translated wrt a Document's baseline reference time. R=sami, rmcilroy BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201338

Patch Set 1 #

Patch Set 2 : fix unit mismatch #

Patch Set 3 : remove redundant doc-time baselining #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -31 lines) Patch
M Source/core/dom/Document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/IdleCallbackDeadline.h View 1 2 2 chunks +8 lines, -10 lines 0 comments Download
M Source/core/dom/IdleCallbackDeadline.cpp View 1 2 1 chunk +5 lines, -6 lines 0 comments Download
M Source/core/dom/ScriptedIdleTaskController.h View 1 2 2 chunks +4 lines, -6 lines 0 comments Download
M Source/core/dom/ScriptedIdleTaskController.cpp View 1 2 5 chunks +5 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
sof
please take a look.
5 years, 3 months ago (2015-08-27 15:00:47 UTC) #2
Sami
I'm not sure how the ms => s unit change is related. Should that be ...
5 years, 3 months ago (2015-08-27 15:18:21 UTC) #3
sof
On 2015/08/27 15:18:21, Sami wrote: > I'm not sure how the ms => s unit ...
5 years, 3 months ago (2015-08-27 15:27:22 UTC) #4
sof
+rmcilroy@
5 years, 3 months ago (2015-08-27 15:28:26 UTC) #6
Sami
Ah, right, I agree that keeping the deadline time (as opposed to the time remaining) ...
5 years, 3 months ago (2015-08-27 15:42:46 UTC) #7
rmcilroy
Thanks for the fix (originally the m_timing object was required because we were returning a ...
5 years, 3 months ago (2015-08-27 16:08:46 UTC) #8
sof
On 2015/08/27 16:08:46, rmcilroy wrote: > Thanks for the fix (originally the m_timing object was ...
5 years, 3 months ago (2015-08-27 18:34:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316323002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316323002/40001
5 years, 3 months ago (2015-08-27 18:46:39 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://src.chromium.org/viewvc/blink?view=rev&revision=201338
5 years, 3 months ago (2015-08-27 20:47:49 UTC) #12
haraken
5 years, 3 months ago (2015-08-27 23:38:39 UTC) #13
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698