Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1316303002: Move a member function intersectsNode() out from VisibleSelection class (Closed)

Created:
5 years, 3 months ago by yosin_UTC9
Modified:
5 years, 3 months ago
Reviewers:
yoichio, hajimehoshi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move a member function intersectsNode() out from VisibleSelection class This patch moves a member function |intersectsNode()| out from |VisibleSelection| class as a preparation of templatizing |VisibleSelection| for introducing composed tree version of |VisibleSelection|. This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1277863002 BUG=513568 TEST=n/a; No behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201304

Patch Set 1 : 2015-08-27T17:53:54 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M Source/core/editing/FrameSelection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/VisibleSelection.h View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/editing/VisibleSelection.cpp View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
yosin_UTC9
PTAL
5 years, 3 months ago (2015-08-27 09:14:05 UTC) #2
hajimehoshi
lgtm
5 years, 3 months ago (2015-08-27 09:16:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316303002/1
5 years, 3 months ago (2015-08-27 09:18:50 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 10:27:54 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201304

Powered by Google App Engine
This is Rietveld 408576698