Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 1316243003: [Android] Adding tests for jlongArray conversions to vectors (Closed)

Created:
5 years, 3 months ago by fgorski
Modified:
5 years, 3 months ago
Reviewers:
nyquist
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Adding tests for jlongArray conversions to vectors I noticed that I didn't have the test for my last checkin and that the method I based mine on didn't have one (perhaps for the same issue I had to add my method). This patch is fixing that. Original checkin: https://codereview.chromium.org/1314753002/ Committed: https://crrev.com/eeea62d3d48453de1a593b9f944523b4ec4f3efc Cr-Commit-Position: refs/heads/master@{#346498}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -0 lines) Patch
M base/android/jni_array_unittest.cc View 1 chunk +55 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fgorski
Tommy, no rush. This is just adding tests to the code I added last time ...
5 years, 3 months ago (2015-08-27 00:16:51 UTC) #2
nyquist
lgtm. thanks for doing this!
5 years, 3 months ago (2015-08-31 21:45:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316243003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316243003/1
5 years, 3 months ago (2015-08-31 22:23:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-31 22:39:19 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-08-31 22:39:49 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eeea62d3d48453de1a593b9f944523b4ec4f3efc
Cr-Commit-Position: refs/heads/master@{#346498}

Powered by Google App Engine
This is Rietveld 408576698