Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1316243002: Define SK_SAVE_LAYER_BOUNDS_ARE_FILTERED for an upcoming Skia change. (Closed)

Created:
5 years, 3 months ago by Stephen White
Modified:
5 years, 3 months ago
Reviewers:
danakj, robertphillips
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Define SK_SAVE_LAYER_BOUNDS_ARE_FILTERED for an upcoming Skia change. Also hide code that depends on saveLayer() bounds being filtered behind the ifdef. BUG=skia:3194 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/0c3b9ee8472937beddabf1f5fa08355cb33aa4dc Cr-Commit-Position: refs/heads/master@{#345985}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add a TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M cc/playback/filter_display_item.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M skia/config/SkUserConfig.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Stephen White
Robert, Dana: PTAL. Thanks!
5 years, 3 months ago (2015-08-26 21:39:04 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316243002/1
5 years, 3 months ago (2015-08-26 22:01:09 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-08-26 23:44:20 UTC) #6
danakj
LGTM https://codereview.chromium.org/1316243002/diff/1/cc/playback/filter_display_item.cc File cc/playback/filter_display_item.cc (right): https://codereview.chromium.org/1316243002/diff/1/cc/playback/filter_display_item.cc#newcode46 cc/playback/filter_display_item.cc:46: #ifdef SK_SAVE_LAYER_BOUNDS_ARE_FILTERED leave a TODO pointing to the ...
5 years, 3 months ago (2015-08-27 18:34:02 UTC) #7
Stephen White
https://codereview.chromium.org/1316243002/diff/1/cc/playback/filter_display_item.cc File cc/playback/filter_display_item.cc (right): https://codereview.chromium.org/1316243002/diff/1/cc/playback/filter_display_item.cc#newcode46 cc/playback/filter_display_item.cc:46: #ifdef SK_SAVE_LAYER_BOUNDS_ARE_FILTERED On 2015/08/27 18:34:02, danakj wrote: > leave ...
5 years, 3 months ago (2015-08-27 19:26:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316243002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316243002/20001
5 years, 3 months ago (2015-08-27 20:28:48 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-08-27 21:05:08 UTC) #12
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 21:06:10 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0c3b9ee8472937beddabf1f5fa08355cb33aa4dc
Cr-Commit-Position: refs/heads/master@{#345985}

Powered by Google App Engine
This is Rietveld 408576698