Adds a WebPageScheduler and a WebFrameScheduler

Adds a WebPageScheduler and a WebFrameScheduler

These APIs are intended to support spatial scheduling and task attribution.

Chromium implementation: https://codereview.chromium.org/1314903007/

BUG=510398
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201978

[alex clarke (OOO till 29th), 2015-09-03 13:29:11]

alexclarke@chromium.org changed reviewers:
+ skyostil@chromium.org

[alex clarke (OOO till 29th), 2015-09-04 09:11:36]

What do you think Sami?

[Sami, 2015-09-04 10:13:35]

Looks good -- just one question.

https://codereview.chromium.org/1316233010/diff/40001/public/platform/WebFram...
File public/platform/WebFrameScheduler.h (right):

https://codereview.chromium.org/1316233010/diff/40001/public/platform/WebFram...
public/platform/WebFrameScheduler.h:30: virtual void setFrameOrigin(const char*)
{ }
Should this be a std::string now given that we can't really guarantee the
lifetime at the calling site?

[alex clarke (OOO till 29th), 2015-09-04 10:19:34]

https://codereview.chromium.org/1316233010/diff/40001/public/platform/WebFram...
File public/platform/WebFrameScheduler.h (right):

https://codereview.chromium.org/1316233010/diff/40001/public/platform/WebFram...
public/platform/WebFrameScheduler.h:30: virtual void setFrameOrigin(const char*)
{ }
On 2015/09/04 10:13:35, Sami wrote:
> Should this be a std::string now given that we can't really guarantee the
> lifetime at the calling site?

Done.

[alex clarke (OOO till 29th), 2015-09-04 10:19:56]

alexclarke@chromium.org changed reviewers:
+ mkwst@chromium.org

[alex clarke (OOO till 29th), 2015-09-04 10:19:56]

mkwst@chromium.org: Can I have an OWNERS review please?

[Sami, 2015-09-04 10:41:54]

Thanks, lgtm.

[Mike West, 2015-09-07 07:45:19]

https://codereview.chromium.org/1316233010/diff/60001/public/platform/WebFram...
File public/platform/WebFrameScheduler.h (right):

https://codereview.chromium.org/1316233010/diff/60001/public/platform/WebFram...
public/platform/WebFrameScheduler.h:32: virtual void setFrameOrigin(const
std::string&) { }
Nit: Be consistent, please. Either `{}` or `{ }` throughout (but I couldn't care
less which you choose. :) ).

`setFrameOrigin` worries me. Especially when it takes a string. What's the
expected use-case of this method? Does it need to care about things like
sandboxing? Would it be reasonable to take a `WebSecurityOrigin` instead of a
String?

[alex clarke (OOO till 29th), 2015-09-08 15:58:05]

PTAL. Sorry for the slow turn around.

https://codereview.chromium.org/1316233010/diff/60001/public/platform/WebFram...
File public/platform/WebFrameScheduler.h (right):

https://codereview.chromium.org/1316233010/diff/60001/public/platform/WebFram...
public/platform/WebFrameScheduler.h:32: virtual void setFrameOrigin(const
std::string&) { }
On 2015/09/07 07:45:18, Mike West (buried) wrote:
> Nit: Be consistent, please. Either `{}` or `{ }` throughout (but I couldn't
care
> less which you choose. :) ).
> 
> `setFrameOrigin` worries me. Especially when it takes a string. What's the
> expected use-case of this method?

Currently it's for annotating task queues in tracing.  I.e. you can see when a
task runs it was associated with foo.com.  This can be useful for diagnosing the
performance of a page with many iframes.

Yes this can take a WebSecurityOrigin.  Done.

[Mike West, 2015-09-08 19:24:58]

LGTM, thanks for the update.

[alex clarke (OOO till 29th), 2015-09-09 13:51:44]

The CQ bit was checked by alexclarke@chromium.org

[alex clarke (OOO till 29th), 2015-09-09 13:51:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
skyostil@chromium.org
Link to the patchset: https://codereview.chromium.org/1316233010/#ps100001
(title: "make white space consistent.")

[commit-bot: I haz the power, 2015-09-09 13:51:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1316233010/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1316233010/100001

[commit-bot: I haz the power, 2015-09-09 14:40:03]

Committed patchset #6 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201978