Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1586)

Side by Side Diff: Source/web/WebViewImpl.cpp

Issue 1316233007: Remove the old didFirstVisuallyNonEmptyLayout hook. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Missed one more thing to remove. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/web/FrameLoaderClientImpl.cpp ('k') | public/web/WebFrameClient.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 1887 matching lines...) Expand 10 before | Expand all | Expand 10 after
1898 for (size_t i = 0; i < m_linkHighlights.size(); ++i) 1898 for (size_t i = 0; i < m_linkHighlights.size(); ++i)
1899 m_linkHighlights[i]->updateGeometry(); 1899 m_linkHighlights[i]->updateGeometry();
1900 1900
1901 if (FrameView* view = mainFrameImpl()->frameView()) { 1901 if (FrameView* view = mainFrameImpl()->frameView()) {
1902 LocalFrame* frame = mainFrameImpl()->frame(); 1902 LocalFrame* frame = mainFrameImpl()->frame();
1903 1903
1904 if (m_shouldDispatchFirstVisuallyNonEmptyLayout && view->isVisuallyNonEm pty()) { 1904 if (m_shouldDispatchFirstVisuallyNonEmptyLayout && view->isVisuallyNonEm pty()) {
1905 m_shouldDispatchFirstVisuallyNonEmptyLayout = false; 1905 m_shouldDispatchFirstVisuallyNonEmptyLayout = false;
1906 // TODO(esprehn): Move users of this callback to something 1906 // TODO(esprehn): Move users of this callback to something
1907 // better, the heuristic for "visually non-empty" is bad. 1907 // better, the heuristic for "visually non-empty" is bad.
1908 // TODO(dglazkov): Remove this line after https://codereview.chromiu m.org/1319073003 lands.
1909 frame->loader().client()->dispatchDidFirstVisuallyNonEmptyLayout();
1910 client()->didFirstVisuallyNonEmptyLayout(); 1908 client()->didFirstVisuallyNonEmptyLayout();
1911 } 1909 }
1912 1910
1913 if (m_shouldDispatchFirstLayoutAfterFinishedParsing && frame->document() ->hasFinishedParsing()) { 1911 if (m_shouldDispatchFirstLayoutAfterFinishedParsing && frame->document() ->hasFinishedParsing()) {
1914 m_shouldDispatchFirstLayoutAfterFinishedParsing = false; 1912 m_shouldDispatchFirstLayoutAfterFinishedParsing = false;
1915 client()->didFirstLayoutAfterFinishedParsing(); 1913 client()->didFirstLayoutAfterFinishedParsing();
1916 } 1914 }
1917 } 1915 }
1918 } 1916 }
1919 1917
(...skipping 2505 matching lines...) Expand 10 before | Expand all | Expand 10 after
4425 if (m_pageColorOverlay) 4423 if (m_pageColorOverlay)
4426 m_pageColorOverlay->update(); 4424 m_pageColorOverlay->update();
4427 if (InspectorOverlayImpl* overlay = inspectorOverlay()) { 4425 if (InspectorOverlayImpl* overlay = inspectorOverlay()) {
4428 PageOverlay* inspectorPageOverlay = overlay->pageOverlay(); 4426 PageOverlay* inspectorPageOverlay = overlay->pageOverlay();
4429 if (inspectorPageOverlay) 4427 if (inspectorPageOverlay)
4430 inspectorPageOverlay->update(); 4428 inspectorPageOverlay->update();
4431 } 4429 }
4432 } 4430 }
4433 4431
4434 } // namespace blink 4432 } // namespace blink
OLDNEW
« no previous file with comments | « Source/web/FrameLoaderClientImpl.cpp ('k') | public/web/WebFrameClient.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698