Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1316233005: Fix GN arm64 build, add msan support in GN. (Closed)

Created:
5 years, 3 months ago by brettw
Modified:
5 years, 3 months ago
Reviewers:
adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix GN arm64 build, add msan support. The arm64 build is missing a few recently-added files. Compiling with msan requires that v8 be compiled in arm64 mode. Hook this up. Committed: https://crrev.com/89ff78f30886aaa866963edef4602fa258f94d5a Cr-Commit-Position: refs/heads/master@{#30528}

Patch Set 1 #

Total comments: 1

Patch Set 2 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M BUILD.gn View 1 2 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
brettw
Jochen is out, Adam can you review?
5 years, 3 months ago (2015-09-01 21:25:59 UTC) #3
adamk
https://codereview.chromium.org/1316233005/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/1316233005/diff/1/BUILD.gn#newcode28 BUILD.gn:28: if (is_msan) { Why is this arm64 only? My ...
5 years, 3 months ago (2015-09-01 21:48:32 UTC) #4
brettw
Good idea. I copied the comment from GYP. This is from common.gypi. If you could ...
5 years, 3 months ago (2015-09-01 21:59:52 UTC) #5
adamk
Thanks, lgtm. The CQ should be able to land for you, let's give it a ...
5 years, 3 months ago (2015-09-01 22:02:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316233005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316233005/20001
5 years, 3 months ago (2015-09-01 22:03:13 UTC) #8
brettw
On 2015/09/01 22:03:13, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
5 years, 3 months ago (2015-09-01 22:12:16 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-01 23:05:26 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 23:05:34 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/89ff78f30886aaa866963edef4602fa258f94d5a
Cr-Commit-Position: refs/heads/master@{#30528}

Powered by Google App Engine
This is Rietveld 408576698