Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1316233003:
By default purge resources that haven't been used for 64 flushes (Closed)
|
Created:
5 years, 3 months ago by bsalomon Modified:
5 years, 2 months ago Reviewers:
robertphillips CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionBy default purge resources that haven't been used for 64 flushes
BUG=skia:4258
Committed: https://skia.googlesource.com/skia/+/85047175508a24f43eef49359bed215a2a3bb104
R=robertphillips@google.com
Committed: https://skia.googlesource.com/skia/+/71d0c33068d41878cc3117f3761f49300f6b3d54
Committed: https://skia.googlesource.com/skia/+/bd783cd5b62118277b75933c3cd7b9097129259a
Committed: https://skia.googlesource.com/skia/+/198a350051824229aa89a5d6348f5a7fc875c9ca
Patch Set 1 #Patch Set 2 : update comment #Patch Set 3 : rebase/retry #Patch Set 4 : Try again with 128 instead of 64 #Patch Set 5 : try again #Messages
Total messages: 25 (8 generated)
bsalomon@google.com changed reviewers: + robertphillips@google.com
The CQ bit was checked by bsalomon@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316233003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316233003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by bsalomon@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316233003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316233003/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/85047175508a24f43eef49359bed215a2a3bb104
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1319053002/ by rmistry@google.com. The reason for reverting is: Suspect for the failed "webgl_conformance on Intel GPU on Mac" test on 2 DEPS rolls: https://codereview.chromium.org/1320943002/ https://codereview.chromium.org/1315703003/ Example build: http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_....
Message was sent while issue was closed.
On 2015/08/27 20:53:37, rmistry wrote: > A revert of this CL (patchset #2 id:20001) has been created in > https://codereview.chromium.org/1319053002/ by mailto:rmistry@google.com. > > The reason for reverting is: Suspect for the failed "webgl_conformance on Intel > GPU on Mac" test on 2 DEPS rolls: > https://codereview.chromium.org/1320943002/ > https://codereview.chromium.org/1315703003/ > > Example build: > http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_.... Here is one more roll that failed with the reverted CL: https://codereview.chromium.org/1321693003 The roll with the revert succeeded: https://codereview.chromium.org/1321693006 Interestingly mac_chromium_rel_ng failed once in that roll too but it looks like it was a different test. The subsequent run worked.
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 71d0c33068d41878cc3117f3761f49300f6b3d54 (presubmit successful).
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1316263003/ by bsalomon@google.com. The reason for reverting is: Blocking roll.
Trying this again at 128. So far unable to reproduce the WebGL conformance test failure. I also tried running the dbg version of the Mac trybot and it passed while the rel consistently fails.
The CQ bit was checked by bsalomon@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from robertphillips@google.com Link to the patchset: https://codereview.chromium.org/1316233003/#ps60001 (title: "Try again with 128 instead of 64")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316233003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316233003/60001
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://skia.googlesource.com/skia/+/bd783cd5b62118277b75933c3cd7b9097129259a
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/1322753004/ by bsalomon@google.com. The reason for reverting is: Breaking again.
The CQ bit was checked by bsalomon@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from robertphillips@google.com Link to the patchset: https://codereview.chromium.org/1316233003/#ps80001 (title: "try again")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316233003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316233003/80001
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://skia.googlesource.com/skia/+/198a350051824229aa89a5d6348f5a7fc875c9ca
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:80001) has been created in https://codereview.chromium.org/1374933004/ by bsalomon@google.com. The reason for reverting is: Breaking conformance test again. |
