src/elements.h - Issue 1316213008: Speedup JSReceiver::GetKeys

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/elements.h

Issue 1316213008: Speedup JSReceiver::GetKeys (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fixing DCHECK Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/elements.h

diff --git a/src/elements.h b/src/elements.h

index bb8b439d727bd33bbc9a962fe718dd57e487ab71..d4e7c7f20f2fad9e663cecf9ecfc787427f5aed6 100644

--- a/src/elements.h

+++ b/src/elements.h

@@ -100,8 +100,8 @@ class ElementsAccessor {

virtual void GrowCapacityAndConvert(Handle<JSObject> object,

uint32_t capacity) = 0;

- virtual Handle<FixedArray> AddElementsToFixedArray(

- Handle<JSObject> receiver, Handle<FixedArray> to,

+ virtual void AddElementsToFixedArrayWithAccumulator(

+ Handle<JSObject> receiver, KeyAccumulator* accumulator,

FixedArray::KeyFilter filter) = 0;

// Returns a shared ElementsAccessor for the specified ElementsKind.

« no previous file with comments | « no previous file | src/elements.cc » ('j') | src/elements.cc » ('J')