Extract common debugger code for processing compile events

Extract common debugger code for processing compile events

BUG=chromium:520702
LOG=N

Committed: https://crrev.com/f987e30a75ec1644e843e5be2e938dc6d8ef1685
Cr-Commit-Position: refs/heads/master@{#30517}

[yurys, 2015-08-31 22:35:46]

https://codereview.chromium.org/1316213005/diff/1/src/debug/debug.cc
File src/debug/debug.cc (right):

https://codereview.chromium.org/1316213005/diff/1/src/debug/debug.cc#newcode1978
src/debug/debug.cc:1978: if (in_nested_debug_scope) {
It is unfortunate that we cannot simply call ProcessDebugEvent here as it would
break order of debug command processing (see e.g.
test-debug/DebugEvaluateWithoutStack) due running command loop on after compile
event. We could pass a flag to ProccessDebugEvent that would tell it to skip
NotifyMessageHandler step but it doesn't look much better. I wish we could drop
this command processing from debug.cc altogether.

[yurys, 2015-08-31 22:36:11]

yurys@chromium.org changed reviewers:
+ kozyatinskiy@chromium.org, yangguo@chromium.org

[yurys, 2015-08-31 22:36:18]

https://codereview.chromium.org/1316213005/diff/1/src/debug/debug.cc
File src/debug/debug.cc (right):

https://codereview.chromium.org/1316213005/diff/1/src/debug/debug.cc#newcode1978
src/debug/debug.cc:1978: if (in_nested_debug_scope) {
It is unfortunate that we cannot simply call ProcessDebugEvent here as it would
break order of debug command processing (see e.g.
test-debug/DebugEvaluateWithoutStack) due running command loop on after compile
event. We could pass a flag to ProccessDebugEvent that would tell it to skip
NotifyMessageHandler step but it doesn't look much better. I wish we could drop
this command processing from debug.cc altogether.

[yurys, 2015-08-31 22:36:25]

The CQ bit was checked by yurys@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-31 22:36:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1316213005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1316213005/1

[kozy, 2015-08-31 22:55:49]

lgtm

[commit-bot: I haz the power, 2015-08-31 23:00:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-31 23:00:58]

Dry run: This issue passed the CQ dry run.

[Yang, 2015-09-01 02:01:43]

lgtm

[yurys, 2015-09-01 16:34:44]

The CQ bit was checked by yurys@chromium.org

[commit-bot: I haz the power, 2015-09-01 16:34:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1316213005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1316213005/1

[commit-bot: I haz the power, 2015-09-01 16:36:20]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-09-01 16:36:38]

Patchset 1 (id:??) landed as
https://crrev.com/f987e30a75ec1644e843e5be2e938dc6d8ef1685
Cr-Commit-Position: refs/heads/master@{#30517}