Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5064)

Unified Diff: chrome/browser/ui/search/instant_controller.h

Issue 13162003: Instant: Don't use the local overlay's URL for the NTP. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/search/instant_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/search/instant_controller.h
diff --git a/chrome/browser/ui/search/instant_controller.h b/chrome/browser/ui/search/instant_controller.h
index ecd333e358f85b96c270420840f3ac3f25306a08..09db21d34428b842e7ad83f6c15c34ec1cdee633 100644
--- a/chrome/browser/ui/search/instant_controller.h
+++ b/chrome/browser/ui/search/instant_controller.h
@@ -216,6 +216,7 @@ class InstantController : public InstantPage::Delegate,
FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest, ValidatesSuggestions);
FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest,
OmniboxCommitsWhenShownFullHeight);
+ FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest, LocalNTPIsNotLocalOverlay);
FRIEND_TEST_ALL_PREFIXES(InstantExtendedManualTest,
MANUAL_OmniboxFocusLoadsInstant);
@@ -312,19 +313,10 @@ class InstantController : public InstantPage::Delegate,
// Send the omnibox popup bounds to the page.
void SendPopupBoundsToPage();
- // Determines the Instant URL based on a number of factors:
- // If |extended_enabled_|:
- // - If |use_local_overlay_only_| is true return kLocalOmniboxPopupURL, else
- // - If the Instant URL is specified by command line, returns it, else
- // - If the default Instant URL is present returns it.
- // If !|extended_enabled_|:
- // - If the Instant URL is specified by command line, returns it, else
- // - If the default Instant URL is present returns it.
- //
- // If |ignore_blacklist| is set to true, Instant URLs are not filtered through
- // the blacklist.
- //
- // Returns true if a valid Instant URL could be found that is not blacklisted.
+ // Returns the default search engine's Instant URL (possibly overridden by
+ // the --instant-url commandline param), if it's not blacklisted already.
+ // Ignores the blacklist if |ignore_blacklist| is true. Returns true if a
+ // valid Instant URL was assigned to |instant_url|; false otherwise.
bool GetInstantURL(Profile* profile,
bool ignore_blacklist,
std::string* instant_url) const;
« no previous file with comments | « no previous file | chrome/browser/ui/search/instant_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698