src/heap/spaces.h - Issue 1316183004: [heap] Throw OOM upon failing to expand a PagedSpace above old gen limits.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/spaces.h

Issue 1316183004: [heap] Throw OOM upon failing to expand a PagedSpace above old gen limits. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Compilation error: size_t vs int Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap/spaces.h

diff --git a/src/heap/spaces.h b/src/heap/spaces.h

index 6af599e02be64f7fd4758f0c9fee10da6b7cd8e2..de82164a1332be17c00c5f2c9e239a4284a1e1cb 100644

--- a/src/heap/spaces.h

+++ b/src/heap/spaces.h

@@ -1919,7 +1919,7 @@ class PagedSpace : public Space {

void EvictEvacuationCandidatesFromFreeLists();

- bool CanExpand();

+ bool CanExpand(size_t size);

// Returns the number of total pages in this space.

int CountTotalPages();

« no previous file with comments | « no previous file | src/heap/spaces.cc » ('j') | no next file with comments »