Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 1316183004: [heap] Throw OOM upon failing to expand a PagedSpace above old gen limits. (Closed)

Created:
5 years, 3 months ago by Michael Lippautz
Modified:
5 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Throw OOM upon failing to expand a PagedSpace above old gen limits. The AlwaysAllocate scope make it impossible to enforce a DCHECK on the maximum old generation sizes as e.g. large objects can still be allocated using this scope. Returning false here results in OOM. R=mstarzinger@chromium.org BUG=chromium:525448 LOG=N Committed: https://crrev.com/61d1cedfb81f302724bc1517ac3a43602efec8b5 Cr-Commit-Position: refs/heads/master@{#30535}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Compilation error: size_t vs int #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M src/heap/spaces.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/heap/spaces.cc View 1 2 1 chunk +7 lines, -8 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
Michael Lippautz
Unless we change AlwaysAllocate's semantics, I think this is the way to go. wdyt?
5 years, 3 months ago (2015-09-01 16:39:59 UTC) #2
Michael Starzinger
LGTM.
5 years, 3 months ago (2015-09-01 17:26:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316183004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316183004/1
5 years, 3 months ago (2015-09-01 17:43:06 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/9346)
5 years, 3 months ago (2015-09-01 17:44:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316183004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316183004/20001
5 years, 3 months ago (2015-09-02 06:43:23 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/9342) v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, ...
5 years, 3 months ago (2015-09-02 06:46:48 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316183004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316183004/40001
5 years, 3 months ago (2015-09-02 06:48:04 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-02 07:20:10 UTC) #16
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 07:20:21 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/61d1cedfb81f302724bc1517ac3a43602efec8b5
Cr-Commit-Position: refs/heads/master@{#30535}

Powered by Google App Engine
This is Rietveld 408576698