Issue 1316163003: Support duration events in `benchmark.mojo`.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1316163003: Support duration events in `benchmark.mojo`. (Closed)

Created:
5 years, 3 months ago by ppi

Modified:
5 years, 3 months ago

Reviewers:
qsr

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Support duration events in `benchmark.mojo`. Fixes #409. R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/421c1f73ffda8bb9502a0755652a456d62441dca

Patch Set 1 #

Patch Set 2 : #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+264 lines, -58 lines)			Patch
M	apps/benchmark/benchmark_app.cc	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	apps/benchmark/event.h	View	1	2 chunks	+18 lines, -3 lines	0 comments	Download
M	apps/benchmark/event.cc	View	1	2 chunks	+136 lines, -24 lines	0 comments	Download
M	apps/benchmark/event_unittest.cc	View		2 chunks	+82 lines, -10 lines	0 comments	Download
M	apps/benchmark/measurements.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	apps/benchmark/measurements.cc	View		4 chunks	+6 lines, -9 lines	0 comments	Download
M	apps/benchmark/measurements_unittest.cc	View		1 chunk	+5 lines, -7 lines	0 comments	Download
M	apps/benchmark/run_args.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/tools/data/benchmarks	View		1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ppi

5 years, 3 months ago (2015-09-08 12:52:39 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
421c1f73ffda8bb9502a0755652a456d62441dca (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages