Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1323)

Unified Diff: Source/core/paint/SVGFilterPainter.cpp

Issue 1316163002: Make the LayoutRect->FloatRect constructor explicit. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/paint/SVGFilterPainter.cpp
diff --git a/Source/core/paint/SVGFilterPainter.cpp b/Source/core/paint/SVGFilterPainter.cpp
index ce909e94b2c5565e2ddca98fe9c767f414fd9333..542e4cf41a76f3c7f13e4da93e47af551fe34932 100644
--- a/Source/core/paint/SVGFilterPainter.cpp
+++ b/Source/core/paint/SVGFilterPainter.cpp
@@ -186,7 +186,8 @@ void SVGFilterPainter::finishEffect(LayoutObject& object, SVGFilterRecordingCont
if (LayoutObjectDrawingRecorder::useCachedDrawingIfPossible(*context, object, DisplayItem::SVGFilter))
return;
- LayoutObjectDrawingRecorder recorder(*context, object, DisplayItem::SVGFilter, LayoutRect::infiniteIntRect());
+ // TODO(chrishtr): stop using an infinite rect, and instead bound the filter.
+ LayoutObjectDrawingRecorder recorder(*context, object, DisplayItem::SVGFilter, LayoutRect(LayoutRect::infiniteIntRect()));
jbroman 2015/08/26 21:45:08 ditto
chrishtr 2015/08/26 22:32:21 No constructor convenience of this type.
jbroman 2015/08/26 22:33:54 If it's not worth adding one, suggest letting the
if (filterData && filterData->m_state == FilterData::ReadyToPaint)
paintFilteredContent(object, context, filterData);
}

Powered by Google App Engine
This is Rietveld 408576698