Source/core/paint/FieldsetPainter.cpp - Issue 1316163002: Make the LayoutRect->FloatRect constructor explicit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/paint/FieldsetPainter.cpp

Issue 1316163002: Make the LayoutRect->FloatRect constructor explicit. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/paint/FieldsetPainter.cpp

diff --git a/Source/core/paint/FieldsetPainter.cpp b/Source/core/paint/FieldsetPainter.cpp

index fcbdf8b16b33274fda85ac212f99580a860c9d4e..57637952fbbcd48e700da2fbce622e4abff8c94a 100644

--- a/Source/core/paint/FieldsetPainter.cpp

+++ b/Source/core/paint/FieldsetPainter.cpp

@@ -40,7 +40,8 @@ void FieldsetPainter::paintBoxDecorationBackground(const PaintInfo& paintInfo, c

paintRect.setX(paintRect.x() + xOff);

}

- LayoutObjectDrawingRecorder recorder(*paintInfo.context, m_layoutFieldset, paintInfo.phase, pixelSnappedIntRect(paintRect));

+ // TODO(chrishtr): pixel-snapping here is likely wrong.

+ LayoutObjectDrawingRecorder recorder(*paintInfo.context, m_layoutFieldset, paintInfo.phase, paintRect);

BoxDecorationData boxDecorationData(m_layoutFieldset);

if (boxDecorationData.bleedAvoidance == BackgroundBleedNone)