Make the LayoutRect->FloatRect constructor explicit.

Source/core/paint/LayoutObjectDrawingRecorder.h

Index: Source/core/paint/LayoutObjectDrawingRecorder.h
diff --git a/Source/core/paint/LayoutObjectDrawingRecorder.h b/Source/core/paint/LayoutObjectDrawingRecorder.h
index cd79523f73d4eafbec90f131847e5889286f5cae..80d423423c25822e29a591dfb8cc69c77ddebf0d 100644
--- a/Source/core/paint/LayoutObjectDrawingRecorder.h
+++ b/Source/core/paint/LayoutObjectDrawingRecorder.h
@@ -31,20 +31,17 @@ public:
         return useCachedDrawingIfPossible(context, layoutObject, DisplayItem::paintPhaseToDrawingType(phase));
     }
 
-    LayoutObjectDrawingRecorder(GraphicsContext& context, const LayoutObject& layoutObject, DisplayItem::Type displayItemType, const FloatRect& clip)
+    LayoutObjectDrawingRecorder(GraphicsContext& context, const LayoutObject& layoutObject, DisplayItem::Type displayItemType, const LayoutRect& clip)

[jbroman, 2015/08/26 19:06:43]

This is the root cause of a bunch of my other comments, but I think this should
probably stay FloatRect (possibly with a LayoutRect overload if the implicit
conversion is going away, for convenience).

There are many call sites where we have an IntRect or FloatRect already, both of
which can be more cheaply and safely converted directly to FloatRect, and floats
are generally the unit from this point in the stack on.

[chrishtr, 2015/08/26 20:53:51]

Done.

     {
         // We may paint a delayed-invalidation object before it's actually invalidated.
         if (layoutObject.fullPaintInvalidationReason() == PaintInvalidationDelayedFull)
             m_cacheSkipper.emplace(context);
-        m_drawingRecorder.emplace(context, layoutObject, displayItemType, clip);
+        m_drawingRecorder.emplace(context, layoutObject, displayItemType, FloatRect(clip));
     }
 
-    LayoutObjectDrawingRecorder(GraphicsContext& context, const LayoutObject& layoutObject, PaintPhase phase, const FloatRect& clip)
+    LayoutObjectDrawingRecorder(GraphicsContext& context, const LayoutObject& layoutObject, PaintPhase phase, const LayoutRect& clip)
         : LayoutObjectDrawingRecorder(context, layoutObject, DisplayItem::paintPhaseToDrawingType(phase), clip) { }
 
-    LayoutObjectDrawingRecorder(GraphicsContext& context, const LayoutObject& layoutObject, DisplayItem::Type type, const LayoutRect& clip)
-        : LayoutObjectDrawingRecorder(context, layoutObject, type, pixelSnappedIntRect(clip)) { }
-
 #if ENABLE(ASSERT)
     void setUnderInvalidationCheckingMode(DrawingDisplayItem::UnderInvalidationCheckingMode mode) { m_drawingRecorder->setUnderInvalidationCheckingMode(mode); }
 #endif