Source/core/paint/ImagePainter.cpp - Issue 1316163002: Make the LayoutRect->FloatRect constructor explicit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/paint/ImagePainter.cpp

Issue 1316163002: Make the LayoutRect->FloatRect constructor explicit. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/paint/FramePainter.cpp ('K') | « Source/core/paint/FramePainter.cpp ('k') | Source/core/paint/InlineFlowBoxPainter.cpp » ('j') | Source/core/paint/LayerClipRecorderTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/paint/ImagePainter.cpp

diff --git a/Source/core/paint/ImagePainter.cpp b/Source/core/paint/ImagePainter.cpp

index 41843b2a01b6d1aa3c52cb2a4b8930dbc489fa48..b3dd8142bb87bac1b0fa9a37ebb84ea842bf0cb0 100644

--- a/Source/core/paint/ImagePainter.cpp

+++ b/Source/core/paint/ImagePainter.cpp

@@ -62,7 +62,7 @@ void ImagePainter::paintAreaElementFocusRing(const PaintInfo& paintInfo)

return;

IntRect focusRect = m_layoutImage.absoluteContentBox();

- LayoutObjectDrawingRecorder drawingRecorder(*paintInfo.context, m_layoutImage, paintInfo.phase, focusRect);

+ LayoutObjectDrawingRecorder drawingRecorder(*paintInfo.context, m_layoutImage, paintInfo.phase, LayoutRect(focusRect));

jbroman 2015/08/26 19:06:43 ditto

chrishtr 2015/08/26 20:53:51 Fixed.

// FIXME: Clip path instead of context when Skia pathops is ready.

// https://crbug.com/251206

@@ -90,7 +90,7 @@ void ImagePainter::paintReplaced(const PaintInfo& paintInfo, const LayoutPoint&

return;

// Draw an outline rect where the image should be.

IntRect paintRect = pixelSnappedIntRect(LayoutRect(paintOffset.x() + m_layoutImage.borderLeft() + m_layoutImage.paddingLeft(), paintOffset.y() + m_layoutImage.borderTop() + m_layoutImage.paddingTop(), cWidth, cHeight));

- LayoutObjectDrawingRecorder drawingRecorder(*context, m_layoutImage, paintInfo.phase, paintRect);

+ LayoutObjectDrawingRecorder drawingRecorder(*context, m_layoutImage, paintInfo.phase, LayoutRect(paintRect));

jbroman 2015/08/26 19:06:43 ditto

chrishtr 2015/08/26 20:53:51 Fixed.

context->setStrokeStyle(SolidStroke);

context->setStrokeColor(Color::lightGray);

context->setFillColor(Color::transparent);

« Source/core/paint/FramePainter.cpp ('K') | « Source/core/paint/FramePainter.cpp ('k') | Source/core/paint/InlineFlowBoxPainter.cpp » ('j') | Source/core/paint/LayerClipRecorderTest.cpp » ('J')