Source/core/paint/FileUploadControlPainter.cpp - Issue 1316163002: Make the LayoutRect->FloatRect constructor explicit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/paint/FileUploadControlPainter.cpp

Issue 1316163002: Make the LayoutRect->FloatRect constructor explicit. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/paint/FileUploadControlPainter.cpp

diff --git a/Source/core/paint/FileUploadControlPainter.cpp b/Source/core/paint/FileUploadControlPainter.cpp

index 479bd661aedc2a332dba4c9efb789d84c03ce006..93f03317f93582592c8b1abb76aacef18f51bd40 100644

--- a/Source/core/paint/FileUploadControlPainter.cpp

+++ b/Source/core/paint/FileUploadControlPainter.cpp

@@ -67,7 +67,7 @@ void FileUploadControlPainter::paintObject(const PaintInfo& paintInfo, const Lay

textWidth, m_layoutFileUploadControl.style()->fontMetrics().height());

// Draw the filename.

- LayoutObjectDrawingRecorder recorder(*paintInfo.context, m_layoutFileUploadControl, paintInfo.phase, textRunPaintInfo.bounds);

+ LayoutObjectDrawingRecorder recorder(*paintInfo.context, m_layoutFileUploadControl, paintInfo.phase, LayoutRect(enclosingIntRect(textRunPaintInfo.bounds)));

jbroman 2015/08/26 19:06:43 ditto

chrishtr 2015/08/26 20:53:51 Reverted.

paintInfo.context->setFillColor(m_layoutFileUploadControl.resolveColor(CSSPropertyColor));

paintInfo.context->drawBidiText(font, textRunPaintInfo, FloatPoint(roundToInt(textX), roundToInt(textY)));

}

« Source/core/paint/FieldsetPainter.cpp ('K') | « Source/core/paint/FieldsetPainter.cpp ('k') | Source/core/paint/FilterPainter.cpp » ('j') | Source/core/paint/FramePainter.cpp » ('J')