Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 1316153002: StackSamplingProfiler: collect partial bursts if the profiler is stopped early (Closed)

Created:
5 years, 3 months ago by Mike Wittman
Modified:
5 years, 3 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkcr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

StackSamplingProfiler: collect partial bursts if the profiler is stopped early Changes the profiler behavior to retain collected samples when the profiler is stopped in the middle of collecting a burst of samples. This behavior is desirable for janky task collection, where we would like to collect up to the point the task completes, but don't know beforehand how long it will take. It's also mildly beneficial for startup profiling in that it allows collection of profiles if Chrome is shut down shortly after being started. BUG=464929 Committed: https://crrev.com/0716a8fedf45c6ecff8b249da926034c34a8ea02 Cr-Commit-Position: refs/heads/master@{#346558}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -27 lines) Patch
M base/profiler/stack_sampling_profiler.h View 2 chunks +8 lines, -8 lines 0 comments Download
M base/profiler/stack_sampling_profiler.cc View 3 chunks +16 lines, -17 lines 0 comments Download
M base/profiler/stack_sampling_profiler_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Mike Wittman
PTAL
5 years, 3 months ago (2015-08-26 17:55:36 UTC) #2
cpu_(ooo_6.6-7.5)
it was lost on me why returning void is better. I liked it better when ...
5 years, 3 months ago (2015-09-01 00:23:17 UTC) #3
Mike Wittman
On 2015/09/01 00:23:17, cpu wrote: > it was lost on me why returning void is ...
5 years, 3 months ago (2015-09-01 00:33:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316153002/1
5 years, 3 months ago (2015-09-01 00:33:26 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/98304)
5 years, 3 months ago (2015-09-01 01:16:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316153002/1
5 years, 3 months ago (2015-09-01 01:17:44 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-01 02:23:39 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 02:24:06 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0716a8fedf45c6ecff8b249da926034c34a8ea02
Cr-Commit-Position: refs/heads/master@{#346558}

Powered by Google App Engine
This is Rietveld 408576698