Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: src/image/SkImage_Raster.cpp

Issue 1316123003: Style Change: SkNEW->new; SkDELETE->delete (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: 2015-08-26 (Wednesday) 15:59:00 EDT Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/image/SkImage_Gpu.cpp ('k') | src/image/SkSurface_Gpu.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2012 Google Inc. 2 * Copyright 2012 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "SkImage_Base.h" 8 #include "SkImage_Base.h"
9 #include "SkBitmap.h" 9 #include "SkBitmap.h"
10 #include "SkCanvas.h" 10 #include "SkCanvas.h"
(...skipping 173 matching lines...) Expand 10 before | Expand all | Expand 10 after
184 184
185 SkImage* SkImage::NewRasterCopy(const SkImageInfo& info, const void* pixels, siz e_t rowBytes, 185 SkImage* SkImage::NewRasterCopy(const SkImageInfo& info, const void* pixels, siz e_t rowBytes,
186 SkColorTable* ctable) { 186 SkColorTable* ctable) {
187 size_t size; 187 size_t size;
188 if (!SkImage_Raster::ValidArgs(info, rowBytes, ctable, &size) || !pixels) { 188 if (!SkImage_Raster::ValidArgs(info, rowBytes, ctable, &size) || !pixels) {
189 return NULL; 189 return NULL;
190 } 190 }
191 191
192 // Here we actually make a copy of the caller's pixel data 192 // Here we actually make a copy of the caller's pixel data
193 SkAutoDataUnref data(SkData::NewWithCopy(pixels, size)); 193 SkAutoDataUnref data(SkData::NewWithCopy(pixels, size));
194 return SkNEW_ARGS(SkImage_Raster, (info, data, rowBytes, ctable, NULL)); 194 return new SkImage_Raster(info, data, rowBytes, ctable, NULL);
195 } 195 }
196 196
197 197
198 SkImage* SkImage::NewRasterData(const SkImageInfo& info, SkData* data, size_t ro wBytes) { 198 SkImage* SkImage::NewRasterData(const SkImageInfo& info, SkData* data, size_t ro wBytes) {
199 size_t size; 199 size_t size;
200 if (!SkImage_Raster::ValidArgs(info, rowBytes, NULL, &size) || !data) { 200 if (!SkImage_Raster::ValidArgs(info, rowBytes, NULL, &size) || !data) {
201 return NULL; 201 return NULL;
202 } 202 }
203 203
204 // did they give us enough data? 204 // did they give us enough data?
205 if (data->size() < size) { 205 if (data->size() < size) {
206 return NULL; 206 return NULL;
207 } 207 }
208 208
209 SkColorTable* ctable = NULL; 209 SkColorTable* ctable = NULL;
210 return SkNEW_ARGS(SkImage_Raster, (info, data, rowBytes, ctable, NULL)); 210 return new SkImage_Raster(info, data, rowBytes, ctable, NULL);
211 } 211 }
212 212
213 SkImage* SkImage::NewFromRaster(const SkImageInfo& info, const void* pixels, siz e_t rowBytes, 213 SkImage* SkImage::NewFromRaster(const SkImageInfo& info, const void* pixels, siz e_t rowBytes,
214 RasterReleaseProc proc, ReleaseContext ctx) { 214 RasterReleaseProc proc, ReleaseContext ctx) {
215 size_t size; 215 size_t size;
216 if (!SkImage_Raster::ValidArgs(info, rowBytes, NULL, &size) || !pixels) { 216 if (!SkImage_Raster::ValidArgs(info, rowBytes, NULL, &size) || !pixels) {
217 return NULL; 217 return NULL;
218 } 218 }
219 219
220 SkColorTable* ctable = NULL; 220 SkColorTable* ctable = NULL;
221 SkAutoDataUnref data(SkData::NewWithProc(pixels, size, proc, ctx)); 221 SkAutoDataUnref data(SkData::NewWithProc(pixels, size, proc, ctx));
222 return SkNEW_ARGS(SkImage_Raster, (info, data, rowBytes, ctable, NULL)); 222 return new SkImage_Raster(info, data, rowBytes, ctable, NULL);
223 } 223 }
224 224
225 SkImage* SkImage::NewFromGenerator(SkImageGenerator* generator, const SkIRect* s ubset) { 225 SkImage* SkImage::NewFromGenerator(SkImageGenerator* generator, const SkIRect* s ubset) {
226 SkBitmap bitmap; 226 SkBitmap bitmap;
227 if (!SkInstallDiscardablePixelRef(generator, subset, &bitmap, NULL)) { 227 if (!SkInstallDiscardablePixelRef(generator, subset, &bitmap, NULL)) {
228 return NULL; 228 return NULL;
229 } 229 }
230 if (0 == bitmap.width() || 0 == bitmap.height()) { 230 if (0 == bitmap.width() || 0 == bitmap.height()) {
231 return NULL; 231 return NULL;
232 } 232 }
233 233
234 return SkNEW_ARGS(SkImage_Raster, (bitmap, NULL)); 234 return new SkImage_Raster(bitmap, NULL);
235 } 235 }
236 236
237 SkImage* SkNewImageFromPixelRef(const SkImageInfo& info, SkPixelRef* pr, 237 SkImage* SkNewImageFromPixelRef(const SkImageInfo& info, SkPixelRef* pr,
238 const SkIPoint& pixelRefOrigin, size_t rowBytes, 238 const SkIPoint& pixelRefOrigin, size_t rowBytes,
239 const SkSurfaceProps* props) { 239 const SkSurfaceProps* props) {
240 if (!SkImage_Raster::ValidArgs(info, rowBytes, NULL, NULL)) { 240 if (!SkImage_Raster::ValidArgs(info, rowBytes, NULL, NULL)) {
241 return NULL; 241 return NULL;
242 } 242 }
243 return SkNEW_ARGS(SkImage_Raster, (info, pr, pixelRefOrigin, rowBytes, props )); 243 return new SkImage_Raster(info, pr, pixelRefOrigin, rowBytes, props);
244 } 244 }
245 245
246 SkImage* SkNewImageFromRasterBitmap(const SkBitmap& bm, const SkSurfaceProps* pr ops, 246 SkImage* SkNewImageFromRasterBitmap(const SkBitmap& bm, const SkSurfaceProps* pr ops,
247 ForceCopyMode forceCopy) { 247 ForceCopyMode forceCopy) {
248 SkASSERT(NULL == bm.getTexture()); 248 SkASSERT(NULL == bm.getTexture());
249 249
250 if (!SkImage_Raster::ValidArgs(bm.info(), bm.rowBytes(), NULL, NULL)) { 250 if (!SkImage_Raster::ValidArgs(bm.info(), bm.rowBytes(), NULL, NULL)) {
251 return NULL; 251 return NULL;
252 } 252 }
253 253
254 SkImage* image = NULL; 254 SkImage* image = NULL;
255 if (kYes_ForceCopyMode == forceCopy || !bm.isImmutable()) { 255 if (kYes_ForceCopyMode == forceCopy || !bm.isImmutable()) {
256 SkBitmap tmp(bm); 256 SkBitmap tmp(bm);
257 tmp.lockPixels(); 257 tmp.lockPixels();
258 if (tmp.getPixels()) { 258 if (tmp.getPixels()) {
259 image = SkImage::NewRasterCopy(tmp.info(), tmp.getPixels(), tmp.rowB ytes(), 259 image = SkImage::NewRasterCopy(tmp.info(), tmp.getPixels(), tmp.rowB ytes(),
260 tmp.getColorTable()); 260 tmp.getColorTable());
261 } 261 }
262 262
263 // we don't expose props to NewRasterCopy (need a private vers) so post- init it here 263 // we don't expose props to NewRasterCopy (need a private vers) so post- init it here
264 if (image && props) { 264 if (image && props) {
265 as_IB(image)->initWithProps(*props); 265 as_IB(image)->initWithProps(*props);
266 } 266 }
267 } else { 267 } else {
268 image = SkNEW_ARGS(SkImage_Raster, (bm, props)); 268 image = new SkImage_Raster(bm, props);
269 } 269 }
270 return image; 270 return image;
271 } 271 }
272 272
273 const SkPixelRef* SkBitmapImageGetPixelRef(const SkImage* image) { 273 const SkPixelRef* SkBitmapImageGetPixelRef(const SkImage* image) {
274 return ((const SkImage_Raster*)image)->getPixelRef(); 274 return ((const SkImage_Raster*)image)->getPixelRef();
275 } 275 }
276 276
277 bool SkImage_Raster::isOpaque() const { 277 bool SkImage_Raster::isOpaque() const {
278 return fBitmap.isOpaque(); 278 return fBitmap.isOpaque();
279 } 279 }
280 280
281 bool SkImage_Raster::onAsLegacyBitmap(SkBitmap* bitmap, LegacyBitmapMode mode) c onst { 281 bool SkImage_Raster::onAsLegacyBitmap(SkBitmap* bitmap, LegacyBitmapMode mode) c onst {
282 if (kRO_LegacyBitmapMode == mode) { 282 if (kRO_LegacyBitmapMode == mode) {
283 // When we're a snapshot from a surface, our bitmap may not be marked im mutable 283 // When we're a snapshot from a surface, our bitmap may not be marked im mutable
284 // even though logically always we are, but in that case we can't physic ally share our 284 // even though logically always we are, but in that case we can't physic ally share our
285 // pixelref since the caller might call setImmutable() themselves 285 // pixelref since the caller might call setImmutable() themselves
286 // (thus changing our state). 286 // (thus changing our state).
287 if (fBitmap.isImmutable()) { 287 if (fBitmap.isImmutable()) {
288 bitmap->setInfo(fBitmap.info(), fBitmap.rowBytes()); 288 bitmap->setInfo(fBitmap.info(), fBitmap.rowBytes());
289 bitmap->setPixelRef(fBitmap.pixelRef(), fBitmap.pixelRefOrigin()); 289 bitmap->setPixelRef(fBitmap.pixelRef(), fBitmap.pixelRefOrigin());
290 return true; 290 return true;
291 } 291 }
292 } 292 }
293 return this->INHERITED::onAsLegacyBitmap(bitmap, mode); 293 return this->INHERITED::onAsLegacyBitmap(bitmap, mode);
294 } 294 }
OLDNEW
« no previous file with comments | « src/image/SkImage_Gpu.cpp ('k') | src/image/SkSurface_Gpu.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698