Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1316063008: Reland: WKWebView: Added cert verification API to web controller. (Closed)

Created:
5 years, 3 months ago by Eugene But (OOO till 7-30)
Modified:
5 years, 3 months ago
Reviewers:
stuartmorgan
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: WKWebView: Added cert verification API to web controller. This code is just a skeleton for verification and verification method is not used for making security decisions or presenting security UI. The decision to use CertVerifier instead of iOS cert verification API has not been made yet. But using CertVerifier is easier for -[WKWebView certificateChain] verification, so this CL uses CertVerifier. Original URL: https://codereview.chromium.org/1230033005/ BUG=462427, 462425 Committed: https://crrev.com/80d735a2bf710864c6f738b8fd05244c54c140ca Cr-Commit-Position: refs/heads/master@{#348699}

Patch Set 1 #

Patch Set 2 : Fixed downstream compilation fixed typo #

Total comments: 2

Patch Set 3 : Removed ENABLE_CHROME_NET_STACK_FOR_WKWEBVIEW guard #

Patch Set 4 : Merged with origin/master #

Patch Set 5 : Gracefully handle null NetLog. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+600 lines, -223 lines) Patch
M ios/web/ios_web.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M ios/web/ios_web_unittests.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M ios/web/net/cert_verifier_block_adapter.h View 2 chunks +39 lines, -26 lines 0 comments Download
M ios/web/net/cert_verifier_block_adapter.cc View 1 2 3 4 1 chunk +56 lines, -47 lines 0 comments Download
M ios/web/net/cert_verifier_block_adapter_unittest.cc View 2 chunks +83 lines, -138 lines 0 comments Download
A ios/web/net/crw_cert_verification_controller.h View 1 1 chunk +68 lines, -0 lines 0 comments Download
A ios/web/net/crw_cert_verification_controller.mm View 1 chunk +194 lines, -0 lines 0 comments Download
A ios/web/net/crw_cert_verification_controller_unittest.mm View 1 chunk +114 lines, -0 lines 0 comments Download
M ios/web/web_state/ui/crw_wk_web_view_web_controller.mm View 1 2 3 6 chunks +42 lines, -12 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Eugene But (OOO till 7-30)
Original patch failed (and reverted) because of dependency CL, which I forgot to land. However ...
5 years, 3 months ago (2015-09-04 18:07:18 UTC) #2
stuartmorgan
Diff lgtm https://codereview.chromium.org/1316063008/diff/20001/ios/web/web_state/ui/crw_wk_web_view_web_controller.mm File ios/web/web_state/ui/crw_wk_web_view_web_controller.mm (right): https://codereview.chromium.org/1316063008/diff/20001/ios/web/web_state/ui/crw_wk_web_view_web_controller.mm#newcode46 ios/web/web_state/ui/crw_wk_web_view_web_controller.mm:46: #if !defined(ENABLE_CHROME_NET_STACK_FOR_WKWEBVIEW) How about we just go ...
5 years, 3 months ago (2015-09-04 18:22:32 UTC) #3
Eugene But (OOO till 7-30)
Thanks! https://codereview.chromium.org/1316063008/diff/20001/ios/web/web_state/ui/crw_wk_web_view_web_controller.mm File ios/web/web_state/ui/crw_wk_web_view_web_controller.mm (right): https://codereview.chromium.org/1316063008/diff/20001/ios/web/web_state/ui/crw_wk_web_view_web_controller.mm#newcode46 ios/web/web_state/ui/crw_wk_web_view_web_controller.mm:46: #if !defined(ENABLE_CHROME_NET_STACK_FOR_WKWEBVIEW) On 2015/09/04 18:22:32, stuartmorgan wrote: > ...
5 years, 3 months ago (2015-09-04 18:39:54 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316063008/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316063008/80001
5 years, 3 months ago (2015-09-14 18:16:37 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-14 19:12:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316063008/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316063008/80001
5 years, 3 months ago (2015-09-14 20:03:16 UTC) #11
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 3 months ago (2015-09-14 20:14:23 UTC) #12
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/80d735a2bf710864c6f738b8fd05244c54c140ca Cr-Commit-Position: refs/heads/master@{#348699}
5 years, 3 months ago (2015-09-14 20:15:06 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:36:29 UTC) #14
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/80d735a2bf710864c6f738b8fd05244c54c140ca
Cr-Commit-Position: refs/heads/master@{#348699}

Powered by Google App Engine
This is Rietveld 408576698