Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1012)

Issue 1316063002: Introduce firstEditablePositionAfterPositionInRoot() (Closed)

Created:
5 years, 3 months ago by yosin_UTC9
Modified:
5 years, 3 months ago
Reviewers:
yoichio, hajimehoshi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Introduce firstEditablePositionAfterPositionInRoot() This patch introduces |firstEditablePositionAfterPositionInRoot()| as pair of |lastEditablePositionBeforePositionInRoot()| to make debugging easier for improving code health. This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1277863002 BUG=513568 TEST=n/a; No behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201220

Patch Set 1 : 2015-08-26T17:01:44 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -8 lines) Patch
M Source/core/editing/EditingUtilities.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/editing/EditingUtilities.cpp View 1 chunk +24 lines, -8 lines 0 comments Download
M Source/core/editing/EditingUtilitiesTest.cpp View 1 chunk +19 lines, -0 lines 1 comment Download

Messages

Total messages: 8 (2 generated)
yosin_UTC9
PTAL
5 years, 3 months ago (2015-08-26 08:24:54 UTC) #2
hajimehoshi
lgtm
5 years, 3 months ago (2015-08-26 08:46:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316063002/1
5 years, 3 months ago (2015-08-26 08:48:07 UTC) #5
yoichio
https://codereview.chromium.org/1316063002/diff/1/Source/core/editing/EditingUtilitiesTest.cpp File Source/core/editing/EditingUtilitiesTest.cpp (right): https://codereview.chromium.org/1316063002/diff/1/Source/core/editing/EditingUtilitiesTest.cpp#newcode26 Source/core/editing/EditingUtilitiesTest.cpp:26: EXPECT_EQ(Position(one, 0), firstEditablePositionAfterPositionInRoot(Position(one, 0), host)); Looks getting same position ...
5 years, 3 months ago (2015-08-26 08:58:26 UTC) #6
yosin_UTC9
On 2015/08/26 08:58:26, yoichio wrote: > https://codereview.chromium.org/1316063002/diff/1/Source/core/editing/EditingUtilitiesTest.cpp > File Source/core/editing/EditingUtilitiesTest.cpp (right): > > https://codereview.chromium.org/1316063002/diff/1/Source/core/editing/EditingUtilitiesTest.cpp#newcode26 > ...
5 years, 3 months ago (2015-08-26 09:17:19 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-08-26 09:31:08 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201220

Powered by Google App Engine
This is Rietveld 408576698