Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: chrome/browser/BUILD.gn

Issue 1316043003: Add chrome://site-engagement WebUI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@navigation_smarter
Patch Set: fix dependencies Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/browser_resources.grd » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/BUILD.gn
diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn
index 2c5489ea90b4c974348bb45b02afbe0e084e3579..5c3ad5207b52945d6c2f5b1d0c06e526e121b1e4 100644
--- a/chrome/browser/BUILD.gn
+++ b/chrome/browser/BUILD.gn
@@ -929,9 +929,6 @@ grit("resources") {
"browser_resources.pak",
]
- omnibox_mojom_file =
- "$root_gen_dir/chrome/browser/ui/webui/omnibox/omnibox.mojom.js"
-
grit_flags = [
"-E",
"about_credits_file=" + rebase_path(about_credits_file, root_build_dir),
@@ -939,7 +936,7 @@ grit("resources") {
"additional_modules_list_file=" +
rebase_path(additional_modules_list_file, root_build_dir),
"-E",
- "omnibox_mojom_file=" + rebase_path(omnibox_mojom_file, root_build_dir),
+ "root_gen_dir=" + rebase_path(root_gen_dir, root_build_dir),
]
deps = [
@@ -948,11 +945,9 @@ grit("resources") {
# Depend only on the generated mojo bindings since we read the .mojom.js
# file, rather than the whole mojo target which will link the C++ bindings.
+ "//chrome/browser/ui/webui/engagement:mojo_bindings__generator",
"//chrome/browser/ui/webui/omnibox:mojo_bindings__generator",
]
- inputs = [
- omnibox_mojom_file,
- ]
}
# GYP version: chrome/chrome_resource.gyp:about_credits
« no previous file with comments | « no previous file | chrome/browser/browser_resources.grd » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698